Skip to content

Fix server error when submitting on non-existent project #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamjallen merged 3 commits into from
Dec 30, 2025
Merged

Fix server error when submitting on non-existent project #3304

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8203516
Fix server error when submitting on non-existent project
Pansysk75 Dec 14, 2025
87d7e2f
Fix server error when submitting on non-existent project
Pansysk75 Dec 14, 2025
d307ac3
Minor updates
williamjallen Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/Http/Controllers/SubmissionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,21 +150,23 @@ private function submitProcess(): Response
// We can't use the usual $this->setProjectByName() function here because the auth token we have might not allow
// full access to the project. E.g., it might be a submit-only token.
$this->project = new Project();
$this->project->FindByName($projectname);

// Remove some old builds if the project has too many.
$this->project->CheckForTooManyBuilds();
if (!$this->project->FindByName($projectname)) {
Storage::delete("inbox/{$filename}");
Log::info("Rejected submission with invalid project name: $projectname");
$this->failProcessing($filename, Response::HTTP_NOT_FOUND, 'The requested project does not exist.');
}

// Check for valid authentication token if this project requires one.
if ($this->project->AuthenticateSubmissions && !AuthTokenUtil::checkToken($authtoken_hash, $this->project->Id)) {
Storage::delete("inbox/{$filename}");
Log::info('Rejected submission with invalid authentication token');
$this->failProcessing(null, Response::HTTP_FORBIDDEN, 'Invalid Token');
} elseif ((int) $this->project->Id < 1) {
Log::info("Rejected submission with invalid project name: $projectname");
$this->failProcessing($filename, Response::HTTP_NOT_FOUND, 'The requested project does not exist.');
}

// Remove some old builds if the project has too many.
$this->project->CheckForTooManyBuilds();

// Figure out what type of XML file this is.
$stored_filename = 'inbox/' . $filename;
$xml_info = SubmissionUtils::get_xml_type(Storage::readStream($stored_filename), $stored_filename);
Expand Down