Fix server error when submitting on non-existent project

[Pansysk75]

Previously, if a submission happened on a non-existent project, the CheckForTooManyBuilds() would result in a 500 http code, which caused me some confusion.

Thanks!

[williamjallen]

Simply relocating the check is not a robust fix. Instead, it would be better to check the return value of $this->project->FindByName($projectname); and use $this->failProcessing() to return an appropriate error if the project does not exist.

[Pansysk75]

Simply relocating the check is not a robust fix. Instead, it would be better to check the return value of $this->project->FindByName($projectname); and use $this->failProcessing() to return an appropriate error if the project does not exist.

That makes sense, thank you for the feedback! I made the requested changes. Please feel free to take the wheel, as I'm not too experienced with either the CDash codebase or php.

[williamjallen]

Thinking about this a bit more, why doesn't this catch the error? Can you post the stack trace for the error you're experiencing?

[Pansysk75]

That place is never reached, as an exception is thrown in this function, called a few lines before that:

CDash/app/Http/Controllers/SubmissionController.php

Line 156 in b1bc0f0

$this->project->CheckForTooManyBuilds();

CDash/app/cdash/app/Model/Project.php

Lines 611 to 615 in b1bc0f0

	public function CheckForTooManyBuilds(): bool
	{
	if (!$this->Id) {
	throw new RuntimeException('ID not set for project');
	}

I also wanted to post the logging output, but I cannot get it to work (storage/logs/cdash.log is empty)