Skip to content

Resolve compatibility issue with current ROLib version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panic-7700 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Resolve compatibility issue with current ROLib version #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d99a55
update csproj to follow conventions in other RO projects; working on …
panic-7700 Apr 30, 2026
b73b483
update syntax for `UpdateDragCubes` call. DragCubeTool seems to be lo…
panic-7700 Apr 30, 2026
1d36956
fix inclusion of assemblies from nuget
panic-7700 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/ROStations/ModuleROStations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,8 @@ public void UpdateAvailableVariants()
/// <summary>
/// Calls the generic ROT procedural drag-cube updating routines. Will update the drag cubes for whatever the current model state is.
/// </summary>
private void UpdateDragCubes() => ROLModInterop.OnPartGeometryUpdate(part, true);
private string ShapeKey => $"ROStations|{coreModule}|{upperModule}|{lowerModule}|{topModule}|{bottomModule}|{bodyRadialModule}|{upperRadialModule}|{lowerRadialModule}|{currentHabitat}|{currentVScale}|{currentDiameter}";
Copy link
Copy Markdown
Author

@panic-7700 panic-7700 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the correct way of creating a uid here. Using currentHabitat seems like it's more likely to pick up changes with the upper/lower/etc modules, but it does not inherently represent external dimensions as the slider can be adjusted independently.

private void UpdateDragCubes() => ROLModInterop.OnPartGeometryUpdate(part, ShapeKey);

private float GetPartTopY()
{
Expand Down
26 changes: 13 additions & 13 deletions Source/ROStations/ROStations.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>ROStations</RootNamespace>
<AssemblyName>ROStations</AssemblyName>
<TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
<TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
Copy link
Copy Markdown
Author

@panic-7700 panic-7700 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TexturesUnlimited seems to have been built with 4.8; when I tried this with 4.7.2, the build did not succeed:

0>Microsoft.Common.CurrentVersion.targets(2437,5): Warning MSB3274 : The primary reference "000_TexturesUnlimited/Plugins/TexturesUnlimited.dll" could not be resolved because it was built against the ".NETFramework,Version=v4.8" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.7.2".

0>ModuleROStations.cs(5,7): Error CS0246 : The type or namespace name 'KSPShaderTools' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(13,87): Error CS0246 : The type or namespace name 'IRecolorable' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(437,16): Error CS0246 : The type or namespace name 'RecoloringData' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(450,54): Error CS0246 : The type or namespace name 'RecoloringData' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(462,16): Error CS0246 : The type or namespace name 'TextureSet' could not be found (are you missing a using directive or an assembly reference?)

<LangVersion>8.0</LangVersion>
<FileAlignment>512</FileAlignment>
<Deterministic>true</Deterministic>
Expand Down Expand Up @@ -50,8 +50,8 @@
<ErrorReport>prompt</ErrorReport>
</PropertyGroup>
<ItemGroup>
<Reference Include="Assembly-CSharp">
<HintPath>..\..\..\..\KSP DLL\1.12.3\Assembly-CSharp.dll</HintPath>
<Reference Include="$(KSPRoot)/KSP_x64_Data/Managed/Assembly-CSharp.dll">
<HintPath>$(ReferencePath)/Assembly-CSharp.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="ROLib">
Expand All @@ -66,24 +66,24 @@
<Reference Include="System.Data" />
<Reference Include="System.Net.Http" />
<Reference Include="System.Xml" />
<Reference Include="TexturesUnlimited">
<HintPath>..\..\..\..\KSP DLL\1.12.3\TexturesUnlimited.dll</HintPath>
<Reference Include="$(KSPRoot)/GameData/000_TexturesUnlimited/Plugins/TexturesUnlimited.dll">
<HintPath>$(ReferencePath)/TexturesUnlimited.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="UnityEngine.CoreModule">
<HintPath>..\..\..\..\KSP DLL\1.12.3\UnityEngine.CoreModule.dll</HintPath>
<Reference Include="$(KSPRoot)/KSP_x64_Data/Managed/UnityEngine.CoreModule.dll">
<HintPath>$(ReferencePath)/UnityEngine.CoreModule.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="UnityEngine.PhysicsModule">
<HintPath>..\..\..\..\KSP DLL\1.12.3\UnityEngine.PhysicsModule.dll</HintPath>
<Reference Include="$(KSPRoot)/KSP_x64_Data/Managed/UnityEngine.PhysicsModule.dll">
<HintPath>$(ReferencePath)/UnityEngine.PhysicsModule.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="UnityEngine.UI">
<HintPath>..\..\..\..\KSP DLL\1.12.3\UnityEngine.UI.dll</HintPath>
<Reference Include="$(KSPRoot)/KSP_x64_Data/Managed/UnityEngine.UI.dll">
<HintPath>$(ReferencePath)/UnityEngine.UI.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="UnityEngine.VehiclesModule">
<HintPath>..\..\..\..\KSP DLL\1.12.3\UnityEngine.VehiclesModule.dll</HintPath>
<Reference Include="$(KSPRoot)/KSP_x64_Data/Managed/UnityEngine.VehiclesModule.dll">
<HintPath>$(ReferencePath)/UnityEngine.VehiclesModule.dll</HintPath>
<Private>False</Private>
</Reference>
</ItemGroup>
Expand Down