Resolve compatibility issue with current ROLib version#1
Open
panic-7700 wants to merge 3 commits into
Open
Conversation
…gging changes correctly.
panic-7700
changed the title
panic-7700
commented
Apr 30, 2026
| <RootNamespace>ROStations</RootNamespace> | ||
| <AssemblyName>ROStations</AssemblyName> | ||
| <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion> | ||
| <TargetFrameworkVersion>v4.8</TargetFrameworkVersion> |
Author
There was a problem hiding this comment.
TexturesUnlimited seems to have been built with 4.8; when I tried this with 4.7.2, the build did not succeed:
0>Microsoft.Common.CurrentVersion.targets(2437,5): Warning MSB3274 : The primary reference "000_TexturesUnlimited/Plugins/TexturesUnlimited.dll" could not be resolved because it was built against the ".NETFramework,Version=v4.8" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.7.2".
0>ModuleROStations.cs(5,7): Error CS0246 : The type or namespace name 'KSPShaderTools' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(13,87): Error CS0246 : The type or namespace name 'IRecolorable' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(437,16): Error CS0246 : The type or namespace name 'RecoloringData' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(450,54): Error CS0246 : The type or namespace name 'RecoloringData' could not be found (are you missing a using directive or an assembly reference?)
0>ModuleROStations.cs(462,16): Error CS0246 : The type or namespace name 'TextureSet' could not be found (are you missing a using directive or an assembly reference?)
panic-7700
commented
Apr 30, 2026
| /// Calls the generic ROT procedural drag-cube updating routines. Will update the drag cubes for whatever the current model state is. | ||
| /// </summary> | ||
| private void UpdateDragCubes() => ROLModInterop.OnPartGeometryUpdate(part, true); | ||
| private string ShapeKey => $"ROStations|{coreModule}|{upperModule}|{lowerModule}|{topModule}|{bottomModule}|{bodyRadialModule}|{upperRadialModule}|{lowerRadialModule}|{currentHabitat}|{currentVScale}|{currentDiameter}"; |
Author
There was a problem hiding this comment.
Not sure if this is the correct way of creating a uid here. Using currentHabitat seems like it's more likely to pick up changes with the upper/lower/etc modules, but it does not inherently represent external dimensions as the slider can be adjusted independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply gets the existing version of ROStations working with the current RO/RP-1 versions. I've made no changes to functionality. I'm new to KSP modding, so let me know if there is any specific testing I should be doing for this!
(I also updated the
.csproj, in the hopes that using theKSPRootglobal would be useful to other folks.)