Remove more bounds checks #661
Merged
+53
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 84.15% 84.18% +0.03%
==========================================
Files 12 12
Lines 9300 9301 +1
==========================================
+ Hits 7826 7830 +4
+ Misses 1474 1471 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Does the |
Contributor
Author
|
The inbounds on nzrange have measurable performance difference for small matrices (less than 10x10 and for about 10%). Definitely not for larger matrices. I did not benchmark the other functions. |
Member
|
This was merged after the v1.13 split. Should this be backported? |
Member
|
Yes, we should backport this. |
dkarrasch
pushed a commit
that referenced
this pull request
Dec 24, 2025
Mostly for `nzrange` but also added more `@inbounds` as I went through the files. All of the functions that has additional `@inbounds` either takes no user index input or have already performed explicit checks on the index (e.g. `isstored`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for
nzrangebut also added more@inboundsas I went through the files. All of the functions that has additional@inboundseither takes no user index input or have already performed explicit checks on the index (e.g.isstored).