Skip to content

Refactor gzip decompression flag to explicitly track success state #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobCoffee merged 2 commits into from
Dec 28, 2025
Merged

Refactor gzip decompression flag to explicitly track success state #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
946f4f8
Initial plan
Copilot Dec 28, 2025
411f864
refactor: rename flag to track decompression success explicitly
Copilot Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/debug_toolbar/litestar/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,21 +493,23 @@ def _inject_toolbar(self, body: bytes, context: RequestContext, content_encoding
import gzip

# Handle gzip-compressed responses
is_gzipped = content_encoding.lower() == "gzip"
if is_gzipped:
# Track whether we successfully decompressed the body
decompressed = False
if content_encoding.lower() == "gzip":
try:
body = gzip.decompress(body)
decompressed = True
except (gzip.BadGzipFile, OSError):
# Not valid gzip, try to decode as-is
is_gzipped = False
pass

try:
html = body.decode("utf-8")
except UnicodeDecodeError:
# Can't decode. If we successfully decompressed gzip, return the
# decompressed body with no content-encoding. Otherwise, return
# the body as-is with the original encoding.
if is_gzipped:
if decompressed:
return body, ""
return body, content_encoding

Expand Down