Refactor gzip decompression flag to explicitly track success state #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is_gzippedvariable in_inject_toolbar()was ambiguous—it initially tracked whether the Content-Encoding header indicated gzip, then was repurposed to track decompression success.Changes
is_gzippedtodecompressedwith explicit success trackinggzip.decompress()succeeds, not based on header presenceis_gzipped = False) with explicit initialization patternBefore:
After:
The flag now unambiguously indicates whether we hold decompressed data, making the subsequent error handling logic clearer.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.