-
Notifications
You must be signed in to change notification settings - Fork 42
[SDK-303] Make the functionality for ios and android the same #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lposen
wants to merge
3
commits into
loren/embedded/SDK-231-ios-add-click-handling-and-track
Choose a base branch
from
loren/embedded/SDK-303-make-the-embedded-functionality-for-ios-and-andrio
base: loren/embedded/SDK-231-ios-add-click-handling-and-track
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { ScrollView, Text, TouchableOpacity, View } from 'react-native'; | ||
| import { ScrollView, Text, TextInput, TouchableOpacity, View } from 'react-native'; | ||
| import { useCallback, useState } from 'react'; | ||
| import { | ||
| Iterable, | ||
|
|
@@ -10,23 +10,25 @@ import { SafeAreaView } from 'react-native-safe-area-context'; | |
| import styles from './Embedded.styles'; | ||
|
|
||
| export const Embedded = () => { | ||
| const [placementIds, setPlacementIds] = useState<number[]>([]); | ||
| const [placementIdsInput, setPlacementIdsInput] = useState<string>(''); | ||
| const [embeddedMessages, setEmbeddedMessages] = useState< | ||
| IterableEmbeddedMessage[] | ||
| >([]); | ||
|
|
||
| // Parse placement IDs from input | ||
| const parsedPlacementIds = placementIdsInput | ||
| .split(',') | ||
| .map((id) => id.trim()) | ||
| .filter((id) => id !== '') | ||
| .map((id) => parseInt(id, 10)) | ||
| .filter((id) => !isNaN(id)); | ||
|
Comment on lines
+19
to
+24
|
||
|
|
||
| const idsToFetch = parsedPlacementIds.length > 0 ? parsedPlacementIds : null; | ||
|
|
||
| const syncEmbeddedMessages = useCallback(() => { | ||
| Iterable.embeddedManager.syncMessages(); | ||
| }, []); | ||
|
|
||
| const getPlacementIds = useCallback(() => { | ||
| return Iterable.embeddedManager.getPlacementIds().then((ids: unknown) => { | ||
| console.log(ids); | ||
| setPlacementIds(ids as number[]); | ||
| return ids; | ||
| }); | ||
| }, []); | ||
|
|
||
| const startEmbeddedSession = useCallback(() => { | ||
| console.log( | ||
| 'startEmbeddedSession --> check android/ios logs to check if it worked' | ||
|
|
@@ -41,12 +43,20 @@ export const Embedded = () => { | |
| Iterable.embeddedManager.endSession(); | ||
| }, []); | ||
|
|
||
| const getEmbeddedMessages = useCallback((ids: number[] | null = null) => { | ||
| Iterable.embeddedManager.getMessages(ids).then((messages: IterableEmbeddedMessage[]) => { | ||
| const getEmbeddedMessages = useCallback(() => { | ||
| // Don't fetch if no IDs | ||
| if (parsedPlacementIds.length === 0) { | ||
| console.log('No placement IDs entered, button should be disabled'); | ||
| return; | ||
| } | ||
|
|
||
| console.log('Fetching messages for placement IDs:', idsToFetch); | ||
|
|
||
| Iterable.embeddedManager.getMessages(idsToFetch).then((messages: IterableEmbeddedMessage[]) => { | ||
| setEmbeddedMessages(messages); | ||
| console.log(messages); | ||
| }); | ||
| }, []); | ||
| }, [idsToFetch, parsedPlacementIds.length]); | ||
|
|
||
| const startEmbeddedImpression = useCallback( | ||
| (message: IterableEmbeddedMessage) => { | ||
|
|
@@ -82,33 +92,55 @@ export const Embedded = () => { | |
|
|
||
| return ( | ||
| <SafeAreaView style={styles.container}> | ||
| <Text style={styles.text}>EMBEDDED</Text> | ||
| <Text style={styles.title}>Embedded</Text> | ||
| {!Iterable.embeddedManager.isEnabled && ( | ||
| <View style={styles.warningContainer}> | ||
| <Text style={styles.warningText}> | ||
| ⚠️ Embedded messaging is disabled. Please enable it in your Iterable config. | ||
| </Text> | ||
| </View> | ||
| )} | ||
| <Text style={styles.subtitle}> | ||
| Enter placement IDs to fetch embedded messages | ||
| </Text> | ||
| <View style={styles.utilitySection}> | ||
| <Text style={styles.text}> | ||
| Does embedded class exist? {Iterable.embeddedManager ? 'Yes' : 'No'} | ||
| </Text> | ||
| <Text style={styles.text}> | ||
| Is embedded manager enabled?{' '} | ||
| {Iterable.embeddedManager.isEnabled ? 'Yes' : 'No'} | ||
| </Text> | ||
| <Text style={styles.text}> | ||
| Placement ids: [{placementIds.join(', ')}] | ||
| </Text> | ||
| <TouchableOpacity style={styles.button} onPress={syncEmbeddedMessages}> | ||
| <Text style={styles.buttonText}>Sync messages</Text> | ||
| </TouchableOpacity> | ||
| <TouchableOpacity style={styles.button} onPress={getPlacementIds}> | ||
| <Text style={styles.buttonText}>Get placement ids</Text> | ||
| </TouchableOpacity> | ||
| <TouchableOpacity style={styles.button} onPress={startEmbeddedSession}> | ||
| <Text style={styles.buttonText}>Start session</Text> | ||
| </TouchableOpacity> | ||
| <TouchableOpacity style={styles.button} onPress={endEmbeddedSession}> | ||
| <Text style={styles.buttonText}>End session</Text> | ||
| </TouchableOpacity> | ||
| <TouchableOpacity style={styles.button} onPress={() => getEmbeddedMessages(placementIds)}> | ||
| <Text style={styles.buttonText}>Get messages</Text> | ||
| </TouchableOpacity> | ||
| <View style={styles.inputContainer}> | ||
| <Text style={styles.text}> | ||
| Placement IDs (comma-separated): | ||
| </Text> | ||
| <TextInput | ||
| style={styles.textInput} | ||
| placeholder="e.g., 1, 2, 3" | ||
| placeholderTextColor="#999" | ||
| value={placementIdsInput} | ||
| onChangeText={setPlacementIdsInput} | ||
| keyboardType="numbers-and-punctuation" | ||
| /> | ||
| <TouchableOpacity | ||
| style={[ | ||
| styles.button, | ||
| parsedPlacementIds.length === 0 && styles.buttonDisabled | ||
| ]} | ||
| onPress={getEmbeddedMessages} | ||
| disabled={parsedPlacementIds.length === 0} | ||
| > | ||
| <Text style={[ | ||
| styles.buttonText, | ||
| parsedPlacementIds.length === 0 && styles.buttonTextDisabled | ||
| ]}> | ||
| Get messages for placement ids | ||
| </Text> | ||
| </TouchableOpacity> | ||
| </View> | ||
| </View> | ||
| <View style={styles.hr} /> | ||
| <ScrollView> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing null to super.onCreate instead of savedInstanceState prevents the restoration of the activity's saved state. This could affect the app's ability to restore its state after configuration changes (like screen rotation) or when the app is killed and restored by the system. While this is example code, it sets a poor pattern for developers who might copy this implementation. If this is necessary for the Iterable SDK to work correctly, it should be documented in the SDK's integration guide with an explanation of why it's needed and what trade-offs it entails.