Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Jan 12, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

  • remove getPlacementsById call
  • clean up the example app

Testing

  • Run the setup
  • Login and then click on the "Embedded" tab
  • The "Get placements" button should no longer be there.
  • You should only be able to get messages if placements are added to the input

Setup

  • cd into root and run yarn install
  • cd into example and run yarn install
  • cd into ios and run bundle exec pod install
  • open two separate terminals.
  • In Terminal 1
    • run watchman watch-del-all
    • run yarn start --reset-cache
  • In Terminal 2
    • cd into ios
    • run open ReactNativeSdkExample.xcworkspace
    • Once Xcode opens the project, choose an emulator then click the play button to run it.

@github-actions
Copy link

Lines Statements Branches Functions
Coverage: 62%
62.54% (389/622) 38.64% (97/251) 61.16% (137/224)

@qltysh
Copy link

qltysh bot commented Jan 12, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on loren/embedded/SDK-231-ios-add-click-handling-and-track by 0.18%.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link

qltysh bot commented Jan 12, 2026

1 new issue

Tool Category Rule Count
qlty Structure Function with high complexity (count = 6): Embedded 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants