Skip to content

added check if the grop exist #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PTKu merged 2 commits into from
Jan 26, 2026
Merged

added check if the grop exist #993

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74828e8
added check if the grop exist
Jan 26, 2026
1aee8bc
Merge branch 'dev' into 992-bug-persistent-data-exchange---read-unkno…
PTKu Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/data/src/AXOpen.Data/DataPersistentExchange/AxoDataPersistentExchange.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,16 @@ private set
/// <returns>Returns true if the read operation is successful; otherwise, false.</returns>
private async Task<bool> ReadTagsFromPlc(string group)
{
var tagsToRead = tagsInGroups[group];
if (tagsToRead != null)
if (tagsInGroups.ContainsKey(group))
{
await _root.GetConnector().ReadBatchAsync(tagsToRead);
return true;
}
else
{
return false;
var tagsToRead = tagsInGroups[group];
if (tagsToRead != null)
{
await _root.GetConnector().ReadBatchAsync(tagsToRead);
return true;
}
}
return false;
}

/// <summary>
Expand Down Expand Up @@ -148,6 +148,8 @@ private void AddTagsFromRecordToWrittenList(List<ITwinPrimitive> tagsToWrite, Pe
/// <returns>Returns true if the update operation is successful; otherwise, false.</returns>
public async Task<bool> UpdatePersistentGroupFromPlcToRepository(string persistentGroupName)
{
if (!tagsInGroups.ContainsKey(persistentGroupName)) return false; // group not exist

await ReadTagsFromPlc(persistentGroupName);

return UpdateReadedTagsToRepository(persistentGroupName);
Expand Down
Loading