added check if the grop exist #993
Merged
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTKu
deleted the
992-bug-persistent-data-exchange---read-unknown-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the
AxoDataPersistentExchangeclass by adding additional checks to ensure group existence before attempting operations. The main changes focus on preventing errors when interacting with groups that may not exist.Validation improvements:
UpdatePersistentGroupFromPlcToRepositoryto returnfalseimmediately if the specified group does not exist intagsInGroups, preventing unnecessary operations.ReadTagsFromPlcto returnfalseif the group does not exist intagsInGroups, making the method's behavior more predictable and robust.