[Fix] Restore visualization feature and refactor RDP utilities into geometry utils #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqiang-yang
approved these changes
Nov 4, 2025
heyi301
pushed a commit
to heyi301/InternNav
that referenced
this pull request
Dec 16, 2025
…eometry utils (InternRobotics#145) * add back visualize feature; refactor rdp utils to geometry utils * remove json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Summary of Changes:
After refactor to new vln_multi_evaluator, the old two evaluators (vln_multi and vln_pe) are merged together. However, the vis_output and save_to_json commit is missed to merge back.
In this pr,
save_to_jsonflag is for online evaluation in eval.ai, keep for future open leaderboardFix #141