fix: remove duplicate bypass allowances from suborg files#1
Merged
Conversation
safe-settings deepMerge concatenates arrays, so having nbrieussel in both settings.yml and each suborg file produced ["nbrieussel","nbrieussel"] after merge. The NOP diff showed this as a deletion — meaning the next real sync would have removed the bypass entirely. Keeping bypass_pull_request_allowances only in settings.yml (org level). The deepMerge carries it through to suborg repos since the suborg files no longer override that key. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bypass_pull_request_allowanceswas added to bothsettings.yml(org level) and all three suborg files["nbrieussel","nbrieussel"]after the org+suborg mergedeletion— meaning the next real sync would have removed the bypass forinfrastructureandgitopsFix: keep
bypass_pull_request_allowancesonly insettings.yml. The deepMerge carries it through to suborg repos since the suborg files no longer define that key.Test plan
nbrieusselcan merge a PR oninfrastructurewithout a second reviewer🤖 Generated with Claude Code