Skip to content

Commit 2fc37a7

Browse files
Nicolas Brieusselclaude
authored andcommitted
fix: remove duplicate bypass_pull_request_allowances from suborgs
safe-settings deepMerge concatenates arrays, so having nbrieussel in both settings.yml and each suborg file produced ["nbrieussel","nbrieussel"] after merge. The NOP diff showed this as a deletion — meaning the next real sync would have removed the bypass entirely. Keeping bypass_pull_request_allowances only in settings.yml (org level). The deepMerge carries it through to suborg repos since the suborg files no longer override that key. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 7369ccc commit 2fc37a7

3 files changed

Lines changed: 3 additions & 15 deletions

File tree

.github/suborgs/backend.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,7 @@ branches:
3232
dismiss_stale_reviews: true
3333
require_code_owner_reviews: false
3434
require_last_push_approval: false
35-
bypass_pull_request_allowances:
36-
apps: []
37-
users:
38-
- nbrieussel
39-
teams: []
35+
4036
required_status_checks:
4137
strict: true # Branch must be up to date with main before merge
4238
contexts: []

.github/suborgs/frontend.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,7 @@ branches:
3030
dismiss_stale_reviews: true
3131
require_code_owner_reviews: false
3232
require_last_push_approval: false
33-
bypass_pull_request_allowances:
34-
apps: []
35-
users:
36-
- nbrieussel
37-
teams: []
33+
3834
required_status_checks:
3935
strict: true
4036
contexts: []

.github/suborgs/infrastructure.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@ branches:
3131
dismiss_stale_reviews: true
3232
require_code_owner_reviews: true # CODEOWNERS file should designate platform team
3333
require_last_push_approval: true # Last commit must be approved by someone else
34-
bypass_pull_request_allowances:
35-
apps: []
36-
users:
37-
- nbrieussel
38-
teams: []
34+
3935
required_status_checks:
4036
strict: true
4137
contexts: []

0 commit comments

Comments
 (0)