Skip to content

Conversation

@blowekamp
Copy link
Member

Replace add_library with itk_module_add_library macro for better integration with ITK module system. This provides automatic dependency linking, include directory setup, and consistent target naming.

Replace add_library with itk_module_add_library macro for better
integration with ITK module system. This provides automatic dependency
linking, include directory setup, and consistent target naming.
@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2026

We probably just need to update the CI.

@blowekamp
Copy link
Member Author

I am struggling with an effective work flow to update these remote modules. I had a local build working with all these changes uncommitted. Now that they are committed the build reset to the hash specified in the repo, and it's broken a gain.

I am also using AI agent to assist with batch running commands. So I apologize if there is a little slop in the commit messages.

Any tips are welcomed.

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2026

To prevent the remote's hash to reverting to what is upstream, set CMake variables Module_XXX_GIT_TAG. In one of my local builds I have Module_MinimalPathExtraction_GIT_TAG set to e43a18f43272bea8c9de5ded7846efbffc81f0ad and Module_Montage_GIT_TAG set to 9aafc48520b2cac963f0f1dfad97b32ed9ab89cf.

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2026

For actual CI updates, it should be as simple as this in majority of cases.

@blowekamp
Copy link
Member Author

To prevent the remote's hash to reverting to what is upstream, set CMake variables Module_XXX_GIT_TAG. In one of my local builds I have Module_MinimalPathExtraction_GIT_TAG set to e43a18f43272bea8c9de5ded7846efbffc81f0ad and Module_Montage_GIT_TAG set to 9aafc48520b2cac963f0f1dfad97b32ed9ab89cf.

That can be cumbersome with multiple remotes being modified... Ideally a flag not to update any of them would be ideal. 🤔

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2026

@copilot create a PR in https://github.com/InsightSoftwareConsortium/ITK implementing Brad's with from previous comment.

Copy link

Copilot AI commented Jan 27, 2026

@dzenanz I've opened a new pull request, #47, to work on those changes. Once the pull request is ready, I'll request review from you.

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2026

Let's see if Copilot can fulfil your wish 😄

@blowekamp blowekamp merged commit ef3756d into main Jan 27, 2026
13 of 50 checks passed
@blowekamp blowekamp deleted the modernize-cmake-itk-module-add-library branch January 27, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants