-
Notifications
You must be signed in to change notification settings - Fork 14
ENH: Modernize CMake to use itk_module_add_library #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace add_library with itk_module_add_library macro for better integration with ITK module system. This provides automatic dependency linking, include directory setup, and consistent target naming.
|
We probably just need to update the CI. |
|
I am struggling with an effective work flow to update these remote modules. I had a local build working with all these changes uncommitted. Now that they are committed the build reset to the hash specified in the repo, and it's broken a gain. I am also using AI agent to assist with batch running commands. So I apologize if there is a little slop in the commit messages. Any tips are welcomed. |
|
To prevent the remote's hash to reverting to what is upstream, set CMake variables |
|
For actual CI updates, it should be as simple as this in majority of cases. |
That can be cumbersome with multiple remotes being modified... Ideally a flag not to update any of them would be ideal. 🤔 |
|
@copilot create a PR in https://github.com/InsightSoftwareConsortium/ITK implementing Brad's with from previous comment. |
|
Let's see if Copilot can fulfil your wish 😄 |
Replace add_library with itk_module_add_library macro for better integration with ITK module system. This provides automatic dependency linking, include directory setup, and consistent target naming.