-
-
Notifications
You must be signed in to change notification settings - Fork 717
ENH: Add ITK_FREEZE_REMOTE_MODULES option to prevent remote module updates #5743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: dzenanz <1792121+dzenanz@users.noreply.github.com>
…dence Co-authored-by: dzenanz <1792121+dzenanz@users.noreply.github.com>
|
Can you give this a try Brad? |
blowekamp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem to work for me.
CMake/ITKDownloadSetup.cmake
Outdated
| OFF | ||
| ) | ||
| mark_as_advanced(ITK_FREEZE_REMOTE_MODULES) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option's location would be better at the top to ITKModuleRemote.cmake file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply this suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the option to the top of ITKModuleRemote.cmake in commit 1c6652d.
Co-authored-by: dzenanz <1792121+dzenanz@users.noreply.github.com>
Description
Developers modifying remote modules lose changes when CMake reconfigures and updates modules to upstream versions. Setting
Module_<name>_GIT_TAGfor each module is cumbersome with multiple remotes.Changes
Added
ITK_FREEZE_REMOTE_MODULESCMake option inITKModuleRemote.cmakeModified
itk_fetch_module()inITKModuleRemote.cmakeModule_<name>_GIT_TAGoverride processingITK_FORBID_DOWNLOADS>Module_<name>_GIT_TAG>ITK_FREEZE_REMOTE_MODULES> empty tag checkUpdated
Modules/Remote/README.mdUsage
PR Checklist
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.