Skip to content

[Snyk] Security upgrade ujson from 5.7.0 to 5.12.0 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashmuck wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade ujson from 5.7.0 to 5.12.0 #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ preshed>=1.0.0,<2.0.0
thinc>=6.10.3,<6.11.0
murmurhash>=0.28,<0.29
plac<1.0.0,>=0.9.6
ujson>=1.35
ujson>=5.12.0
Copy link
Copy Markdown

@cursor cursor Bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security fix incomplete: setup.py ujson version not updated

High Severity

The ujson version constraint in requirements.txt was bumped to >=5.12.0 to fix security vulnerabilities, but setup.py install_requires still specifies ujson>=1.35. Anyone installing this package via pip install . or from PyPI will resolve the old, vulnerable ujson version. The security fix is effectively incomplete because setup.py is the authoritative source for package installation dependencies.

Fix in Cursor Fix in Web

Copy link
Copy Markdown

@cursor cursor Bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ujson 5.12.0 requires Python 3.10, breaking project compatibility

High Severity

ujson>=5.12.0 requires Python 3.10+, but this project declares support for Python 2.7, 3.4, 3.5, and 3.6 in its setup.py classifiers. Installing with requirements.txt will fail on every Python version this project officially supports, since none of them meet ujson 5.12.0's minimum Python requirement.

Fix in Cursor Fix in Web

dill>=0.2,<0.3
regex==2017.4.5
requests>=2.13.0,<3.0.0
Expand Down
Loading