Skip to content

[Snyk] Security upgrade ujson from 5.7.0 to 5.12.0#19

Open
ashmuck wants to merge 1 commit intomasterfrom
snyk-fix-809c4b14ec75a8793e296c3b2a99545c
Open

[Snyk] Security upgrade ujson from 5.7.0 to 5.12.0#19
ashmuck wants to merge 1 commit intomasterfrom
snyk-fix-809c4b14ec75a8793e296c3b2a99545c

Conversation

@ashmuck
Copy link

@ashmuck ashmuck commented Mar 19, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • requirements.txt

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Integer Overflow or Wraparound
🦉 Missing Release of Memory after Effective Lifetime


Note

Low Risk
Low risk dependency-only change; main concern is potential minor behavior/performance differences in ujson affecting JSON serialization/deserialization at runtime.

Overview
Upgrades the ujson dependency in requirements.txt to >=5.12.0 to address reported security vulnerabilities.

Written by Cursor Bugbot for commit 26b0bf1. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

murmurhash>=0.28,<0.29
plac<1.0.0,>=0.9.6
ujson>=1.35
ujson>=5.12.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security fix incomplete: setup.py ujson version not updated

High Severity

The ujson version constraint in requirements.txt was bumped to >=5.12.0 to fix security vulnerabilities, but setup.py install_requires still specifies ujson>=1.35. Anyone installing this package via pip install . or from PyPI will resolve the old, vulnerable ujson version. The security fix is effectively incomplete because setup.py is the authoritative source for package installation dependencies.

Fix in Cursor Fix in Web

murmurhash>=0.28,<0.29
plac<1.0.0,>=0.9.6
ujson>=1.35
ujson>=5.12.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ujson 5.12.0 requires Python 3.10, breaking project compatibility

High Severity

ujson>=5.12.0 requires Python 3.10+, but this project declares support for Python 2.7, 3.4, 3.5, and 3.6 in its setup.py classifiers. Installing with requirements.txt will fail on every Python version this project officially supports, since none of them meet ujson 5.12.0's minimum Python requirement.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants