Skip to content

Leave room in _DcmAttribute to NUL-terminate a 63-character keyword #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcupitt merged 1 commit into from
Apr 18, 2025
Merged

Leave room in _DcmAttribute to NUL-terminate a 63-character keyword #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## main

* fix one-byte overread into struct padding [bgilbert]

## 1.2.0, 09/04/2025

* fix build with uthash \< 2.3.0 [bgilbert]
Expand Down
2 changes: 1 addition & 1 deletion src/dicom-dict-tables.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ typedef enum _DcmVRTag {
struct _DcmAttribute {
uint32_t tag;
DcmVRTag vr_tag;
char keyword[63];
char keyword[64];
};

extern const struct _DcmAttribute dcm_attribute_table[];
Expand Down