Leave room in _DcmAttribute to NUL-terminate a 63-character keyword
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"FrameOfReferenceToDisplayedCoordinateSystemTransformationMatrix" is 63
characters and we need room for the trailing NUL. While the compiler
would have added a trailing 0 byte anyway to maintain struct alignment,
reading the string would invoke undefined behavior.
Fixes a warning on GCC 15:
../src/dicom-dict-tables.c:3296:33: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (64 chars into 63 available) [-Wunterminated-string-initialization]
3296 | {0X0070030B, DCM_VR_TAG_FD, "FrameOfReferenceToDisplayedCoordinateSystemTransformationMatrix"}
Collaborator
Author
|
Actually this isn't so harmless, since the one-byte overread is undefined behavior. Updated the changelog and description. |
Collaborator
|
Ooop! Thank for this Benjamin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameOfReferenceToDisplayedCoordinateSystemTransformationMatrixis 63 characters and we need room for the trailing NUL. While the compiler would have added a trailing 0 byte anyway to maintain struct alignment, reading the string would invoke undefined behavior.Fixes a warning on GCC 15: