[tools] Fix mingw toolchain rc file handling #1285
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the toolchain just passes the .rc file to the c++ compiler which results in the following warning:
This means no object file is generated for the .rc, so this is followed by an error during link time:
windresis a utility that's part of mingw for processing.rcfiles, so that should be used here. We want to generate.ofiles instead of.resfiles like with msvc, since mingw cannot process.resfiles.With this patch it is possible to build a haxe app using
-D resourceFile=ApplicationMain.rcwithout linking errors. It is possible to verify that the resource has been added correctly, for example if the company name has been set:exiftool bin/HelloWorld.exe | grep -i company