Skip to content

Conversation

@MAJigsaw77
Copy link
Contributor

@MAJigsaw77 MAJigsaw77 commented Feb 10, 2025

This PR introduces support for embedding version information into the application's .exe file.

@MAJigsaw77 MAJigsaw77 marked this pull request as draft February 10, 2025 21:55
@joshtynjala joshtynjala linked an issue Feb 10, 2025 that may be closed by this pull request
@ACrazyTown
Copy link
Contributor

Semi-related, but I noticed the commit (HaxeFoundation/hxcpp@b045f25) mentioned in the linked issue also adds support for manifests. I think this would allow for proper high dpi support on Windows

@MAJigsaw77 MAJigsaw77 marked this pull request as ready for review February 11, 2025 12:00
@dimensionscape dimensionscape merged commit c4cc642 into openfl:8.3.0-Dev Feb 11, 2025
30 checks passed
@MAJigsaw77 MAJigsaw77 deleted the feature/resource-file-windows branch February 11, 2025 12:46
@tobil4sk
Copy link
Member

tobil4sk commented Jan 5, 2026

Looks like this accidentally broke mingw builds, though it is due to a problem in hxcpp: HaxeFoundation/hxcpp#1285

It gives output like this in case any other users run into this:

 - Running command: x86_64-w64-mingw32-g++ -c -Wno-overflow -g -O2 -DHXCPP_M64 -DHXCPP_VISIT_ALLOCS -DHX_SMART_STRINGS -DHXCPP_API_LEVEL=430 -DHX_WINDOWS -m64 -DHXCPP_M64 -I/.../hxcpp/include ./ApplicationMain.rc -o/.../HelloWorld/Export/windows/obj/obj/mingw64-nc/20eab515_ApplicationMain.o
x86_64-w64-mingw32-g++: warning: ./ApplicationMain.rc: linker input file unused because linking not done
[...]
 - Link: ApplicationMain.exe: x86_64-w64-mingw32-g++ -o ApplicationMain.exe -Wl,--enable-auto-import -mwindows -m64 -L/usr/x86_64-w64-mingw32/lib/libs @obj/mingw64-nc/all_objs -lws2_32
/usr/lib/gcc/x86_64-w64-mingw32/15.2.0/../../../../x86_64-w64-mingw32/bin/ld: cannot find obj/mingw64-nc/20eab515_ApplicationMain.o: No such file or directory
collect2: error: ld returned 1 exit status
Error: Error while running command
x86_64-w64-mingw32-g++ -o ApplicationMain.exe -Wl,--enable-auto-import -mwindows -m64 -L/usr/x86_64-w64-mingw32/lib/libs @obj/mingw64-nc/all_objs -lws2_32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for embedded version information on Windows

4 participants