Fix hammer and miner drop crushing not checking all recipes#4492
Open
screret wants to merge 5 commits intoGregTechCEu:1.21from
Open
Fix hammer and miner drop crushing not checking all recipes#4492screret wants to merge 5 commits intoGregTechCEu:1.21from
screret wants to merge 5 commits intoGregTechCEu:1.21from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the hammer & large miner drop raw ore -> crushed ore conversion only ever checking the first recipe it came across and discarding the miner output if it's invalid, instead of checking all discovered recipes.
I also cached the loot functions after they're created & added the proper value the LootContext's random secuence so anything that uses it (e.g. loot modifiers) is now deterministic, as it would be if it was just mined from the world.
Implementation Details
Made the recipe checking use a loop instead of only looking at the first recipe returned by the iterator
changed lot of nested if statements to guard clauses so the code is more readable
Outcome
Fixed a potential bug and made the code neater (maybe even faster!) :3
Additional Information
The other change in gtceu.mixins.json was done automatically by IntelliJ and it kept (re)doing that so I gave up reverting it after a while.
This PR was split off from #4421.