Use enchantment tags for tool enchantment checks#4494
Open
screret wants to merge 8 commits intoGregTechCEu:1.21from
Open
Use enchantment tags for tool enchantment checks#4494screret wants to merge 8 commits intoGregTechCEu:1.21from
screret wants to merge 8 commits intoGregTechCEu:1.21from
Conversation
…sc/use-tags-for-tool-enchantment-checks
…ts instead of hardcoding the enchantment to check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR makes the enchantment checks in ToolEventHandler.onHarvestDrops and BlockMixin use enchantment tags instead of hardcoding the specific enchantment they test for.
As they are, they can cause crashes because data packs can remove enchantments.
Implementation Details
For all the applicable cases, I used the same utility function vanilla uses for silk touch: EnchantmentHelper.hasTag.
A tag for enchants that block hammer drop conversion was added. Currently, it only contains silk touch.
Outcome
Fixes a possible bug with enchantment checking, and allows mod- and datapack developers to change what enchantments fill the described conditions
Additional Information
This pull request depends on changes done in #4492, so that should be merged first.