Lang Refactor by Spicierspace153 · Pull Request #3246 · GregTechCEu/GregTech-Modern

Spicierspace153 · 2025-06-20T07:47:02Z

What

Refactors a majority of where we generate lang keys.

Implementation Details

Removed all of the lang generated values from LangHandler, and moved them into dedicated classes, went through each class and sectioned each lang by relation to each other.

Outcome

The overall structure should be easier to navigate where a lang key would be. All language keys should be intact.
Fixed some minor lang keys, will comb through all lang keys in a later pr

…yo/space-tooltip-refactor # Conflicts: # src/generated/resources/assets/gtceu/lang/en_ud.json # src/generated/resources/assets/gtceu/lang/en_us.json # src/main/java/com/gregtechceu/gtceu/api/cover/filter/TagFilter.java # src/main/java/com/gregtechceu/gtceu/api/machine/SimpleTieredMachine.java # src/main/java/com/gregtechceu/gtceu/client/TooltipsHandler.java # src/main/java/com/gregtechceu/gtceu/common/data/GTItems.java # src/main/java/com/gregtechceu/gtceu/common/data/GTMachines.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTResearchMachines.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/BlockBreakerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/FisherMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/ItemCollectorMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/MinerMachine.java # src/main/java/com/gregtechceu/gtceu/data/lang/ArmorLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/CommandLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/LangHandler.java # src/main/java/com/gregtechceu/gtceu/data/lang/MaterialLang.java

…chCEu/GregTech-Modern into yo/space-tooltip-refactor # Conflicts: # src/main/java/com/gregtechceu/gtceu/data/lang/ConfigurationLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/CoverLang.java

…d files

… into yo/space-tooltip-refactor # Conflicts: # src/generated/resources/assets/gtceu/lang/en_ud.json # src/generated/resources/assets/gtceu/lang/en_us.json # src/main/java/com/gregtechceu/gtceu/data/lang/LangHandler.java

screret · 2025-06-24T20:43:29Z

+     * @param key Base key of the multi lang. E.g. "terminal.fluid_prospector.tier".
+     * @return Returns all translation components from a multi lang's sub-keys
+     */
+    public static List<MutableComponent> getMultiLang(String key) {


if you change this to return a Component[] you won't need to call toArray(Component[]::new) every time you use it :3

you can also keep the original method and just add a wrapper that does the array conversion

screret · 2025-06-24T21:19:04Z

        var damage = getPartDamage(stack);
        tooltipComponents
-                .add(Component.translatable("metaitem.tool.tooltip.durability", maxDurability - damage, maxDurability));
+                .add(Component.translatable("item.tool.tooltip.durability", maxDurability - damage, maxDurability));


is this the correct key?

yes its only used by TurbineRotorBehavior anyways

screret · 2025-06-24T21:24:02Z

all of the already resolved comments are me marking what I'd like stuff be changed to later, you can ignore them for now if you so choose

screret

oh, before I forget:
change the recipe type lang keys to recipe_type.gtceu.type, because currently they're just gtceu.type, which is probably the worst possible design decision.

YoungOnionMC · 2025-06-25T02:20:41Z

oh, before I forget: change the recipe type lang keys to recipe_type.gtceu.type, because currently they're just gtceu.type, which is probably the worst possible design decision.

you could put then in the new pr when we make it :)

…s, enchantments

…ategory lang, coil lang formatting, spotless

…large boiler tooltips, start tooltips for multiblocks

Co-authored-by: screret <68943070+screret@users.noreply.github.com>

AveryAndCompany · 2025-07-17T00:42:00Z

IC Chip -> ILC Chip

Parallel Hatch odd phrasing
"Allows to run up to 4 recipes in parallel" -> Consider: "Allows running up to 4 recipes in parallel"

…factor # Conflicts: # gradle/forge.versions.toml # src/generated/resources/assets/gtceu/lang/en_ud.json # src/generated/resources/assets/gtceu/lang/en_us.json # src/main/java/com/gregtechceu/gtceu/api/block/PipeBlock.java # src/main/java/com/gregtechceu/gtceu/api/capability/IPropertyFluidFilter.java # src/main/java/com/gregtechceu/gtceu/api/item/IGTTool.java # src/main/java/com/gregtechceu/gtceu/api/item/PipeBlockItem.java # src/main/java/com/gregtechceu/gtceu/api/item/component/ThermalFluidStats.java # src/main/java/com/gregtechceu/gtceu/api/machine/SimpleTieredMachine.java # src/main/java/com/gregtechceu/gtceu/api/recipe/GTRecipeType.java # src/main/java/com/gregtechceu/gtceu/api/registry/registrate/GTRegistrate.java # src/main/java/com/gregtechceu/gtceu/client/TooltipsHandler.java # src/main/java/com/gregtechceu/gtceu/common/CommonProxy.java # src/main/java/com/gregtechceu/gtceu/common/block/CoilBlock.java # src/main/java/com/gregtechceu/gtceu/common/block/FluidPipeBlock.java # src/main/java/com/gregtechceu/gtceu/common/block/LaserPipeBlock.java # src/main/java/com/gregtechceu/gtceu/common/block/OpticalPipeBlock.java # src/main/java/com/gregtechceu/gtceu/common/data/GCYMRecipeTypes.java # src/main/java/com/gregtechceu/gtceu/common/data/GTBlocks.java # src/main/java/com/gregtechceu/gtceu/common/data/GTMachines.java # src/main/java/com/gregtechceu/gtceu/common/data/GTRecipeTypes.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GCYMMachines.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTMachineUtils.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTMultiMachines.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTResearchMachines.java # src/main/java/com/gregtechceu/gtceu/common/item/armor/NanoMuscleSuite.java # src/main/java/com/gregtechceu/gtceu/common/item/armor/QuarkTechSuite.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/BlockBreakerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/ConverterMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/FisherMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/ItemCollectorMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/MinerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/TransformerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/electric/WorldAcceleratorMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/DiodePartMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/storage/DrumMachine.java # src/main/java/com/gregtechceu/gtceu/config/ConfigHolder.java # src/main/java/com/gregtechceu/gtceu/core/mixins/top/ConfigMixin.java # src/main/java/com/gregtechceu/gtceu/data/GregTechDatagen.java # src/main/java/com/gregtechceu/gtceu/data/lang/BlockLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/ConfigurationLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/IntegrationLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/ItemLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/LangHandler.java # src/main/java/com/gregtechceu/gtceu/data/lang/MachineLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/MaterialLangGenerator.java # src/main/java/com/gregtechceu/gtceu/data/lang/ToolLang.java # src/main/java/com/gregtechceu/gtceu/integration/jade/provider/SteamBoilerBlockProvider.java # src/main/java/com/gregtechceu/gtceu/integration/top/provider/HazardCleanerInfoProvider.java # src/main/java/com/gregtechceu/gtceu/integration/top/provider/SteamBoilerInfoProvider.java # src/main/resources/assets/gtceu/lang/ja_jp.json # src/main/resources/assets/gtceu/lang/ru_ru.json # src/main/resources/assets/gtceu/lang/uk_ua.json # src/main/resources/assets/gtceu/lang/zh_cn.json # src/main/resources/assets/gtceu/lang/zh_tw.json # src/main/resources/gtceu.mixins.json

YoungOnionMC and others added 14 commits June 19, 2025 19:19

start of lang restructuring

8695821

better file system for lang keys

4f9c495

missed this one :(

d5d50ca

lang util

04313ff

armorLang.java cleanup

6f83930

more renames to armor and lang handler javadoc for proper practice

38de8ef

someone(onion) forgot to change uses when moving classes

d74ae71

final ArmorLang

8cd8c4f

Fluid Lang Keys rename :)

716fab8

tool lang, command lang, fix missing cut paste errors

fc8c460

start of covers

b67220a

Merge branch 'yo/space-tooltip-refactor' of https://github.com/GregTe…

fe289db

…chCEu/GregTech-Modern into yo/space-tooltip-refactor # Conflicts: # src/main/java/com/gregtechceu/gtceu/data/lang/ConfigurationLang.java # src/main/java/com/gregtechceu/gtceu/data/lang/CoverLang.java

subtitles

5ee9e18

Spicierspace153 requested a review from a team as a code owner June 20, 2025 07:47

Spicierspace153 marked this pull request as draft June 20, 2025 07:47

JuiceyBeans mentioned this pull request Jun 20, 2025

Tooltips R' Us #2099

Closed

finish the moving of LangHandler, all lang values are now in dedicate…

d7a80ec

…d files

YoungOnionMC force-pushed the yo/space-tooltip-refactor branch from 4679868 to d7a80ec Compare June 22, 2025 07:45

remove juicers pr

aacf2e3

YoungOnionMC force-pushed the yo/space-tooltip-refactor branch from 7ed21a9 to aacf2e3 Compare June 23, 2025 05:59

YoungOnionMC added 3 commits June 23, 2025 00:09

merge 1.20.1 pre 7.0

62ecda5

more Lang cleanup, fix various broken lang keys

311d0f3

YoungOnionMC changed the title ~~lang key refactor of doom~~ Lang Refactor Jun 23, 2025

YoungOnionMC added the type: refactor Suggestion to refactor a section of code label Jun 23, 2025

YoungOnionMC added 2 commits June 24, 2025 01:50

machine lang 😭

5f65c80

GUI Lang

0678b22

Spicierspace153 marked this pull request as ready for review June 24, 2025 20:36

requested changes

e782584

screret suggested changes Jun 24, 2025

View reviewed changes

YoungOnionMC and others added 13 commits June 24, 2025 23:42

requested changes

ba989df

Pipe connection tooltips

304c680

recipe type names and categories

5f1902b

cauldron washing tooltip keys

36e21a1

tool behaviors, tool class, tool info tooltips, turbine rotor tooltip…

0872d8c

…s, enchantments

Armor Lang Refactor (#3274)

f9e9b61

armor lang datagen

f8d944b

configuration lang, add entire path to the keys

76345d0

Fluid pipe tooltips, item pipe tooltips, cable tooltips, fluid tooltips

d7fe386

UHV-MAX machine lang, eu generator tooltip blurbs, fixed xei recipe c…

00e5698

…ategory lang, coil lang formatting, spotless

gtceu.machine -> machine.gtceu, fix hard coded recipe type mod lang, …

c67b507

…large boiler tooltips, start tooltips for multiblocks

remove upside down lang (#3278)

1d0e176

Co-authored-by: screret <68943070+screret@users.noreply.github.com>

more machine tooltips

81120cf

jurrejelle marked this pull request as draft July 6, 2025 14:02

Ghostipedia added the Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release label Jul 18, 2025

YoungOnionMC added 2 commits May 19, 2026 18:16

slams keyboard

0c115ff

github-actions Bot added 1.20.1 Tests: Passed Game Tests have passed on this PR labels May 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lang Refactor#3246

Lang Refactor#3246
Spicierspace153 wants to merge 37 commits into
1.20.1from
yo/space-tooltip-refactor

Spicierspace153 commented Jun 20, 2025 •

edited by YoungOnionMC

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

screret Jun 24, 2025

Uh oh!

screret Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

screret Jun 24, 2025

Uh oh!

YoungOnionMC Jun 26, 2025

Uh oh!

screret commented Jun 24, 2025

Uh oh!

screret left a comment

Uh oh!

YoungOnionMC commented Jun 25, 2025

Uh oh!

AveryAndCompany commented Jul 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Spicierspace153 commented Jun 20, 2025 • edited by YoungOnionMC Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Implementation Details

Outcome

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

screret Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

screret Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

screret Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

YoungOnionMC Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

screret commented Jun 24, 2025

Uh oh!

screret left a comment

Choose a reason for hiding this comment

Uh oh!

YoungOnionMC commented Jun 25, 2025

Uh oh!

AveryAndCompany commented Jul 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Spicierspace153 commented Jun 20, 2025 •

edited by YoungOnionMC

Loading