Tooltips R' Us#2099
Closed
JuiceyBeans wants to merge 17 commits into
Closed
Conversation
screret
reviewed
Oct 10, 2024
Comment on lines
+50
to
+55
| if (this instanceof OpticalPipeBlockItem) { | ||
| if (GTUtil.isShiftDown()) { | ||
| tooltip.add(Component.translatable("gtceu.tool_action.wire_cutter.connect")); | ||
| } else { | ||
| tooltip.add(Component.translatable("gtceu.tool_action.show_tooltips")); | ||
| } |
Contributor
There was a problem hiding this comment.
just override it in OpticalPipeBlockItem?
Contributor
There was a problem hiding this comment.
If you override it, then you have to call super().
But if you call super() it'll add the wrench tooltip.
But if you don't call super then you don't get the block tooltip unless you manually call this.getBlock().appendHoverText() in the override for this tooltip.
It's a mess overall D:
screret
added
the
type: feature
Contributor
Author
|
Superseded by #3246, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bunch of changes to tooltips for 1.12 parity, fixes, and consistency
Implementation Details
Will close #2431
Proposed format for tooltip formatting
KEY1 + KEY2(for example,SHIFT + R-CLICK)