implement extended sysprop overrides for hide carrier info feature#66
Open
maade93791 wants to merge 6 commits intoGrapheneOS:16-qpr2from
Open
implement extended sysprop overrides for hide carrier info feature#66maade93791 wants to merge 6 commits intoGrapheneOS:16-qpr2from
maade93791 wants to merge 6 commits intoGrapheneOS:16-qpr2from
Conversation
the implementation is entirely copied from appcompat overrides, with several changes: * deny writes to a set of sysprops * inherit overrides from `ro.appcompat_override`
upon further research this approach caused more issues than it solved, for instance, after bind mount when find() actually return non-null value, which breaks the expected behaviour, of the props but being set up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.