add per-app setting for hiding carrier/network information#340
Open
maade93791 wants to merge 7 commits intoGrapheneOS:16-qpr2from
Open
add per-app setting for hiding carrier/network information#340maade93791 wants to merge 7 commits intoGrapheneOS:16-qpr2from
maade93791 wants to merge 7 commits intoGrapheneOS:16-qpr2from
Conversation
|
I'm not sure how large the scope of this feature is, but is the intention to completely block all access to these properties? (eg. including apps that use bionic libc's |
Member
Author
|
@chenxiaolong its being worked on. |
maade93791
force-pushed
the
16-qpr2-carrier-info
branch
from
f7495f7 to
c319b26
Compare
RankoR
reviewed
May 4, 2026
|
|
||
| /** @hide */ | ||
| public class AswHideCarrierInfo extends AppSwitch { | ||
| public static final AswHideCarrierInfo I = new AswHideCarrierInfo(); |
There was a problem hiding this comment.
We should use more descriptive var names, I think
Member
Author
There was a problem hiding this comment.
other AppSwtich implementations use this naming scheme (e.g. AswBlockPlayIntegrityApi, AswDenyNativeDebug and so on), i went off that.
RankoR
reviewed
May 4, 2026
| } | ||
|
|
||
| @Override | ||
| public Boolean getImmutableValue(Context ctx, int userId, ApplicationInfo appInfo, |
There was a problem hiding this comment.
Methods that may return null should be marked with @Nullable
Member
Author
There was a problem hiding this comment.
base AppSwitch class doesnt declare that, didnt include it for consistency
maade93791
force-pushed
the
16-qpr2-carrier-info
branch
from
c319b26 to
9befca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current implementation handles
gsm.{operator,sim}sysprops and TelephonyManager calls that expose information for the currently installed SIM/eSIM state, its carrier and the network the connected to. also enforce CountryDetector.getCountry() to rely only on last known location and device locale, when feature is enabled.to be merged with: GrapheneOS/platform_packages_apps_Settings#425