Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ai-platform/snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0",
"uuid": "^11.1.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The uuid package version 11.x requires Node.js 18 or higher. This package specifies node: >=16.0.0 in its engines field (line 7). Upgrading to ^11.1.0 will break compatibility for users on Node.js 16. This issue is present across most package.json files updated in this PR where the engine requirement is less than 18.

Suggested change
"uuid": "^11.1.0",
"uuid": "^10.0.0",

"sinon": "^18.0.0"
}
}

2 changes: 1 addition & 1 deletion appengine/storage/flexible/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"mocha": "^10.2.0",
"proxyquire": "^2.1.3",
"supertest": "^7.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"mocha": "^10.2.0",
"proxyquire": "^2.1.3",
"supertest": "^6.3.3",
"uuid": "^9.0.0"
"uuid": "^11.1.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This sample is explicitly intended for Node.js 16, as indicated by the directory name and the engines field ("node": "16.x.x" on line 9). Upgrading to uuid v11 (which requires Node.js 18+) is a breaking change for this sample's target environment.

Suggested change
"uuid": "^11.1.0"
"uuid": "^10.0.0"

}
}
2 changes: 1 addition & 1 deletion appengine/storage/standard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"mocha": "^10.2.0",
"proxyquire": "^2.1.3",
"supertest": "^7.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion asset/snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
"gts": "^5.0.0",
"mocha": "^10.0.0",
"sinon": "^18.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"devDependencies": {
"c8": "^10.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion automl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion cloud-language/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion cloud-tasks/snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion compute/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
"chai": "^4.5.0",
"mocha": "^10.0.0",
"proxyquire": "^2.0.1",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion contact-center-insights/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion container-analysis/snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion datacatalog/cloud-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"devDependencies": {
"c8": "^10.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@google-cloud/datacatalog": "^4.0.0"
Expand Down
2 changes: 1 addition & 1 deletion datacatalog/quickstart/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"devDependencies": {
"c8": "^10.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@google-cloud/datacatalog": "^4.0.0"
Expand Down
2 changes: 1 addition & 1 deletion datacatalog/snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"chai": "^4.5.0",
"execa": "^9.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion dataproc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion datastore/functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"node-fetch": "^3.0.0",
"proxyquire": "^2.1.0",
"sinon": "^18.0.0",
"uuid": "^10.0.0",
"uuid": "^11.1.0",
"wait-port": "^1.0.4"
}
}
2 changes: 1 addition & 1 deletion dialogflow-cx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion dialogflow/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion discoveryengine/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"devDependencies": {
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion dlp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
"pngjs": "^7.0.0",
"proxyquire": "^2.1.3",
"sinon": "^18.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion document-ai/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion eventarc/generic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
"mocha": "^10.0.0",
"sinon": "^18.0.0",
"supertest": "^7.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion functions/firebase/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"proxyquire": "^2.1.0",
"sinon": "^18.0.0",
"supertest": "^7.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@google-cloud/firestore": "^7.0.0"
Expand Down
2 changes: 1 addition & 1 deletion functions/helloworld/helloGCS/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"moment": "^2.24.0",
"promise-retry": "^2.0.0",
"sinon": "^18.0.0",
"uuid": "^10.0.0",
"uuid": "^11.1.0",
"wait-port": "^1.0.4"
}
}
2 changes: 1 addition & 1 deletion functions/helloworld/helloPubSub/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"moment": "^2.29.4",
"promise-retry": "^2.0.0",
"sinon": "^18.0.0",
"uuid": "^10.0.0",
"uuid": "^11.1.0",
"wait-port": "^1.0.4"
}
}
2 changes: 1 addition & 1 deletion functions/helloworld/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"promise-retry": "^2.0.0",
"sinon": "^18.0.0",
"supertest": "^7.0.0",
"uuid": "^10.0.0",
"uuid": "^11.1.0",
"wait-port": "^1.0.4"
}
}
2 changes: 1 addition & 1 deletion functions/v2/autoLabelInstance/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"p-retry": "^6.0.0",
"sinon": "^18.0.0",
"supertest": "^7.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion functions/v2/helloPubSub/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"mocha": "^10.0.0",
"sinon": "^18.0.0",
"supertest": "^7.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion genai/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"node-fetch": "^2.7.0",
"proxyquire": "^2.1.3",
"sinon": "^18.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion generative-ai/snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"chai": "^4.5.0",
"mocha": "^10.0.0",
"sinon": "^18.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion healthcare/consent/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"devDependencies": {
"c8": "^10.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@googleapis/healthcare": "^23.0.0"
Expand Down
2 changes: 1 addition & 1 deletion healthcare/datasets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"devDependencies": {
"c8": "^10.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@googleapis/healthcare": "^23.0.0"
Expand Down
2 changes: 1 addition & 1 deletion healthcare/dicom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@google-cloud/storage": "^7.0.0",
"c8": "^10.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@googleapis/healthcare": "^23.0.0"
Expand Down
2 changes: 1 addition & 1 deletion healthcare/fhir/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"c8": "^10.0.0",
"google-auth-library": "^9.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@googleapis/healthcare": "^23.0.0"
Expand Down
2 changes: 1 addition & 1 deletion healthcare/hl7v2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@google-cloud/pubsub": "^4.0.0",
"c8": "^10.0.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
},
"dependencies": {
"@googleapis/healthcare": "^23.0.0"
Expand Down
46 changes: 23 additions & 23 deletions iam/deny/package.json
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
{
"name": "nodejs-docs-samples-iam",
"private": true,
"license": "Apache-2.0",
"author": "Google Inc.",
"repository": {
"type": "git",
"url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
},
"engines": {
"node": ">=16.0.0"
},
"scripts": {
"test": "c8 mocha -p -j 2 test/*.test.js --timeout=60000"
},
"dependencies": {
"@google-cloud/iam": "^1.0.0"
},
"devDependencies": {
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
}
"name": "nodejs-docs-samples-iam",
"private": true,
"license": "Apache-2.0",
"author": "Google Inc.",
"repository": {
"type": "git",
"url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
},
"engines": {
"node": ">=16.0.0"
},
"scripts": {
"test": "c8 mocha -p -j 2 test/*.test.js --timeout=60000"
},
"dependencies": {
"@google-cloud/iam": "^1.0.0"
},
"devDependencies": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file has been entirely reformatted, changing indentation from 4 spaces to 2 spaces. While 2-space indentation is standard for this repository, this change is out of scope for a dependency update. Per the general rules, pull requests should remain focused on a single concern.

References
  1. Keep pull requests focused on a single concern. Defer out-of-scope changes to a separate pull request.

"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion kms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion media/livestream/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.1.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion media/transcoder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"@google-cloud/storage": "^7.0.0",
"c8": "^10.0.0",
"mocha": "^10.1.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion media/video-stitcher/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"c8": "^10.0.0",
"chai": "^4.5.0",
"mocha": "^10.1.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion monitoring/snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"devDependencies": {
"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0"
"uuid": "^11.1.0"
}
}
2 changes: 1 addition & 1 deletion parametermanager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"c8": "^10.1.3",
"chai": "^4.5.0",
"mocha": "^11.1.0",
"uuid": "^11.0.5"
"uuid": "^11.1.0"
}
}
Loading
Loading