-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: update uuid package to ^11.1.0 across samples (b/508686791) #4309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,6 @@ | |
| "mocha": "^10.2.0", | ||
| "proxyquire": "^2.1.3", | ||
| "supertest": "^7.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -24,6 +24,6 @@ | |||||
| "mocha": "^10.2.0", | ||||||
| "proxyquire": "^2.1.3", | ||||||
| "supertest": "^6.3.3", | ||||||
| "uuid": "^9.0.0" | ||||||
| "uuid": "^11.1.0" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sample is explicitly intended for Node.js 16, as indicated by the directory name and the
Suggested change
|
||||||
| } | ||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,6 @@ | |
| "mocha": "^10.2.0", | ||
| "proxyquire": "^2.1.3", | ||
| "supertest": "^7.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,6 @@ | |
| "gts": "^5.0.0", | ||
| "mocha": "^10.0.0", | ||
| "sinon": "^18.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,6 @@ | |
| "devDependencies": { | ||
| "c8": "^10.0.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,6 @@ | |
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "proxyquire": "^2.0.1", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,6 @@ | |
| "chai": "^4.5.0", | ||
| "execa": "^9.0.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,6 @@ | |
| "devDependencies": { | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,6 @@ | |
| "pngjs": "^7.0.0", | ||
| "proxyquire": "^2.1.3", | ||
| "sinon": "^18.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,6 @@ | |
| "mocha": "^10.0.0", | ||
| "sinon": "^18.0.0", | ||
| "supertest": "^7.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,6 @@ | |
| "p-retry": "^6.0.0", | ||
| "sinon": "^18.0.0", | ||
| "supertest": "^7.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,6 @@ | |
| "mocha": "^10.0.0", | ||
| "sinon": "^18.0.0", | ||
| "supertest": "^7.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,6 @@ | |
| "node-fetch": "^2.7.0", | ||
| "proxyquire": "^2.1.3", | ||
| "sinon": "^18.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,6 @@ | |
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "sinon": "^18.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,25 @@ | ||
| { | ||
| "name": "nodejs-docs-samples-iam", | ||
| "private": true, | ||
| "license": "Apache-2.0", | ||
| "author": "Google Inc.", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git" | ||
| }, | ||
| "engines": { | ||
| "node": ">=16.0.0" | ||
| }, | ||
| "scripts": { | ||
| "test": "c8 mocha -p -j 2 test/*.test.js --timeout=60000" | ||
| }, | ||
| "dependencies": { | ||
| "@google-cloud/iam": "^1.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| } | ||
| "name": "nodejs-docs-samples-iam", | ||
| "private": true, | ||
| "license": "Apache-2.0", | ||
| "author": "Google Inc.", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git" | ||
| }, | ||
| "engines": { | ||
| "node": ">=16.0.0" | ||
| }, | ||
| "scripts": { | ||
| "test": "c8 mocha -p -j 2 test/*.test.js --timeout=60000" | ||
| }, | ||
| "dependencies": { | ||
| "@google-cloud/iam": "^1.0.0" | ||
| }, | ||
| "devDependencies": { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file has been entirely reformatted, changing indentation from 4 spaces to 2 spaces. While 2-space indentation is standard for this repository, this change is out of scope for a dependency update. Per the general rules, pull requests should remain focused on a single concern. References
|
||
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.1.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,6 @@ | |
| "@google-cloud/storage": "^7.0.0", | ||
| "c8": "^10.0.0", | ||
| "mocha": "^10.1.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,6 @@ | |
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.1.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,6 @@ | |
| "devDependencies": { | ||
| "chai": "^4.5.0", | ||
| "mocha": "^10.0.0", | ||
| "uuid": "^10.0.0" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,6 @@ | |
| "c8": "^10.1.3", | ||
| "chai": "^4.5.0", | ||
| "mocha": "^11.1.0", | ||
| "uuid": "^11.0.5" | ||
| "uuid": "^11.1.0" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
uuidpackage version 11.x requires Node.js 18 or higher. This package specifiesnode: >=16.0.0in itsenginesfield (line 7). Upgrading to^11.1.0will break compatibility for users on Node.js 16. This issue is present across mostpackage.jsonfiles updated in this PR where the engine requirement is less than 18.