Skip to content

chore: update uuid package to ^11.1.0 across samples (b/508686791)#4309

Open
angelcaamal wants to merge 3 commits intomainfrom
chore/update-uuid-package
Open

chore: update uuid package to ^11.1.0 across samples (b/508686791)#4309
angelcaamal wants to merge 3 commits intomainfrom
chore/update-uuid-package

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented May 7, 2026

Description

Fixes Internal: b/508686791

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudfunctions Issues related to the Cloud Run functions API. api: compute Issues related to the Compute Engine API. api: contactcenterinsights Issues related to the Contact Center AI Insights API. api: containeranalysis Issues related to the Container Analysis API. api: datacatalog Issues related to the Data Catalog API. api: dataproc Issues related to the Dataproc API. api: datastore Issues related to the Datastore API. api: dialogflow Issues related to the Dialogflow API. api: discoveryengine Issues related to the Discovery Engine API API. api: dlp Issues related to the Sensitive Data Protection API. api: documentai Issues related to the Document AI API. api: eventarc Issues related to the Eventarc API. api: language Issues related to the Cloud Natural Language API API. api: tasks Issues related to the Tasks API API. asset: pattern DEE Asset tagging - Pattern. labels May 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the uuid dependency to version 11.1.0 across numerous packages and introduces reformatting in iam/deny/package.json. The review feedback correctly identifies that uuid v11 requires Node.js 18 or higher, which creates compatibility issues with several packages that specify older Node.js versions in their engines field. Furthermore, the indentation changes in iam/deny/package.json are noted as out-of-scope for a dependency update PR.

"chai": "^4.5.0",
"mocha": "^10.0.0",
"uuid": "^10.0.0",
"uuid": "^11.1.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The uuid package version 11.x requires Node.js 18 or higher. This package specifies node: >=16.0.0 in its engines field (line 7). Upgrading to ^11.1.0 will break compatibility for users on Node.js 16. This issue is present across most package.json files updated in this PR where the engine requirement is less than 18.

Suggested change
"uuid": "^11.1.0",
"uuid": "^10.0.0",

"proxyquire": "^2.1.3",
"supertest": "^6.3.3",
"uuid": "^9.0.0"
"uuid": "^11.1.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This sample is explicitly intended for Node.js 16, as indicated by the directory name and the engines field ("node": "16.x.x" on line 9). Upgrading to uuid v11 (which requires Node.js 18+) is a breaking change for this sample's target environment.

Suggested change
"uuid": "^11.1.0"
"uuid": "^10.0.0"

Comment thread storage/package.json
"@google-cloud/storage": "^7.19.0",
"node-fetch": "^2.6.7",
"uuid": "^8.0.0",
"uuid": "^11.1.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

uuid is listed as a production dependency here. Version 11.x dropped support for Node.js versions earlier than 18. This package specifies node: >=12 in its engines field (line 7). This update will prevent the sample from running on Node.js 12, 14, and 16. Please either update the engines requirement or use a compatible version of uuid (e.g., ^9.0.0 for Node 12+ or ^10.0.0 for Node 14+).

Suggested change
"uuid": "^11.1.0",
"uuid": "^9.0.0",

Comment thread iam/deny/package.json
"dependencies": {
"@google-cloud/iam": "^1.0.0"
},
"devDependencies": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file has been entirely reformatted, changing indentation from 4 spaces to 2 spaces. While 2-space indentation is standard for this repository, this change is out of scope for a dependency update. Per the general rules, pull requests should remain focused on a single concern.

References
  1. Keep pull requests focused on a single concern. Defer out-of-scope changes to a separate pull request.

@angelcaamal angelcaamal marked this pull request as ready for review May 7, 2026 16:46
@angelcaamal angelcaamal requested review from a team as code owners May 7, 2026 16:46
@angelcaamal angelcaamal requested review from a team as code owners May 7, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudfunctions Issues related to the Cloud Run functions API. api: compute Issues related to the Compute Engine API. api: contactcenterinsights Issues related to the Contact Center AI Insights API. api: containeranalysis Issues related to the Container Analysis API. api: datacatalog Issues related to the Data Catalog API. api: dataproc Issues related to the Dataproc API. api: datastore Issues related to the Datastore API. api: dialogflow Issues related to the Dialogflow API. api: discoveryengine Issues related to the Discovery Engine API API. api: dlp Issues related to the Sensitive Data Protection API. api: documentai Issues related to the Document AI API. api: eventarc Issues related to the Eventarc API. api: language Issues related to the Cloud Natural Language API API. api: tasks Issues related to the Tasks API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants