-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/highlight vertex #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
61200cd
temp schemas and logic
MaxNumerique 7e0e5fe
refacto ?
MaxNumerique b144623
Apply prepare changes
MaxNumerique c3853af
refacto
MaxNumerique 6af2cf5
Merge branch 'feat/highlightVertex' of https://github.com/Geode-solut…
MaxNumerique 822ace2
Merge branch 'next' of https://github.com/Geode-solutions/OpenGeodeWe…
MaxNumerique a53e76e
Merge branch 'next' of https://github.com/Geode-solutions/OpenGeodeWe…
MaxNumerique 09fde19
Merge branch 'feat/highlightVertex' of https://github.com/Geode-solut…
MaxNumerique 17b16b7
models
MaxNumerique 8d1e74e
Merge branch 'feat/highlightVertex' of https://github.com/Geode-solut…
MaxNumerique 928e810
Apply prepare changes
MaxNumerique 6c0611d
refacto
MaxNumerique 75fe274
Merge branch 'feat/highlightVertex' of https://github.com/Geode-solut…
MaxNumerique 15b6493
Apply prepare changes
MaxNumerique 4154e71
color green
MaxNumerique 855bd6b
Merge branch 'feat/highlightVertex' of https://github.com/Geode-solut…
MaxNumerique 3ad5f45
SetRelativeCoincidentTopologyPolygonOffsetParameters for both highlights
MaxNumerique 848e3a3
temp
MaxNumerique 19227c5
harmonize logic between highlights methods
MaxNumerique 8426339
Merge branch 'feat/highlightVertex' of https://github.com/Geode-solut…
MaxNumerique 3805f42
Apply prepare changes
MaxNumerique cc69bee
highlight over setuphighlight
MaxNumerique 8af8e37
Merge branch 'feat/highlightVertex' of https://github.com/Geode-solut…
MaxNumerique c443493
more refacto
MaxNumerique 333ccf2
fix imports
MaxNumerique a135988
actor.SetUseBounds(False)
MaxNumerique 2758704
highlight
MaxNumerique File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,4 +61,3 @@ wslink==1.12.4 | |
| yarl>=1 | ||
| # via aiohttp | ||
|
|
||
| opengeodeweb-microservice==1.*,>=1.1.3 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
src/opengeodeweb_viewer/rpc/viewer/schemas/hover_highlight.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "rpc": "hover_highlight", | ||
| "type": "object", | ||
| "properties": { | ||
| "x": { | ||
| "type": "number" | ||
| }, | ||
| "y": { | ||
| "type": "number" | ||
| }, | ||
| "field_type": { | ||
| "enum": ["CELL", "POINT"] | ||
| }, | ||
| "ids": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "minLength": 1 | ||
| } | ||
| } | ||
| }, | ||
| "required": ["x", "y", "field_type", "ids"], | ||
| "additionalProperties": false | ||
| } |
20 changes: 20 additions & 0 deletions
20
src/opengeodeweb_viewer/rpc/viewer/schemas/hover_highlight.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| from dataclasses_json import DataClassJsonMixin | ||
| from enum import Enum | ||
| from dataclasses import dataclass | ||
| from typing import List | ||
|
|
||
|
|
||
| class FieldType(Enum): | ||
| CELL = "CELL" | ||
| POINT = "POINT" | ||
|
|
||
|
|
||
| @dataclass | ||
| class HoverHighlight(DataClassJsonMixin): | ||
| def __post_init__(self) -> None: | ||
| print(self, flush=True) | ||
|
|
||
| field_type: FieldType | ||
| ids: List[str] | ||
| x: float | ||
| y: float |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En fait si on veut harmoniser et utiliser vtkSelectionNode.BLOCKS, on aura une sortie en vtkMultiBlocksDataSet, alors que le mapper qu'on a pourle highlight est vtkDataSetMapper et n'accepte que les objets qui héritent de vtkDataSet.
Donc soit on garde ce vtkAppendDataSets pour fusionner les blocs du vtkMultiBlocksDataSet extrait en un seul vkDataSet
ou
on change dynamiquement le type de mapper, mais je ne sais pas si ça complexifie trop pour juste ça ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BotellaA