Feat/highlight vertex#148
Merged
Merged
Conversation
…ions/OpenGeodeWeb-Viewer into feat/highlightVertex
…b-Viewer into feat/highlightVertex
…b-Viewer into feat/highlightVertex
…ions/OpenGeodeWeb-Viewer into feat/highlightVertex
…ions/OpenGeodeWeb-Viewer into feat/highlightVertex
…ions/OpenGeodeWeb-Viewer into feat/highlightVertex
…ions/OpenGeodeWeb-Viewer into feat/highlightVertex
BotellaA
reviewed
May 15, 2026
…ions/OpenGeodeWeb-Viewer into feat/highlightVertex
…ions/OpenGeodeWeb-Viewer into feat/highlightVertex
MaxNumerique
commented
May 18, 2026
Comment on lines
+170
to
+179
| append = vtkAppendDataSets() | ||
| for i in params.block_ids: | ||
| block = ( | ||
| pipeline.blockDataSets[i] | ||
| if i < len(pipeline.blockDataSets) | ||
| else None | ||
| ) | ||
| if isinstance(block, vtkDataSet): | ||
| append.AddInputData(block) | ||
| append.Update() |
Contributor
Author
There was a problem hiding this comment.
En fait si on veut harmoniser et utiliser vtkSelectionNode.BLOCKS, on aura une sortie en vtkMultiBlocksDataSet, alors que le mapper qu'on a pourle highlight est vtkDataSetMapper et n'accepte que les objets qui héritent de vtkDataSet.
Donc soit on garde ce vtkAppendDataSets pour fusionner les blocs du vtkMultiBlocksDataSet extrait en un seul vkDataSet
ou
on change dynamiquement le type de mapper, mais je ne sais pas si ça complexifie trop pour juste ça ?
BotellaA
approved these changes
May 18, 2026
Member
|
🎉 This PR is included in version 1.19.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.