Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,25 @@ AlwaysBreakTemplateDeclarations: true
BinPackArguments: true
BinPackParameters: false
BraceWrapping:
AfterClass: true
AfterControlStatement: true
AfterEnum: true
AfterFunction: true
AfterNamespace: true
AfterObjCDeclaration: true
AfterStruct: true
AfterUnion: true
BeforeCatch: true
BeforeElse: true
IndentBraces: false
AfterClass: true
AfterControlStatement: true
AfterEnum: true
AfterFunction: true
AfterNamespace: true
AfterObjCDeclaration: true
AfterStruct: true
AfterUnion: true
BeforeCatch: true
BeforeElse: true
IndentBraces: false
BreakBeforeBinaryOperators: NonAssignment
BreakBeforeBraces: Custom
BreakBeforeTernaryOperators: true
BreakConstructorInitializers: BeforeColon
BreakInheritanceList: BeforeColon
#BreakStringLiterals
ColumnLimit: 80
CommentPragmas: ''
CommentPragmas: ""
CompactNamespaces: false
ConstructorInitializerAllOnOneLineOrOnePerLine: true
ConstructorInitializerIndentWidth: 4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
typename Model::Builder& builder,
const geode::ModelCopyMapping& mapping )
{
for( const auto& [in, _] :

Check warning on line 51 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:51:27 [readability-identifier-length]

variable name 'in' is too short, expected at least 3 characters
mapping.at( geode::Corner< Model::dim >::component_type_static() )
.in2out_map() )
{
Expand Down Expand Up @@ -130,7 +130,7 @@
}

template < typename Model >
void set_corner_meshes_in_mapping( const Model& model,

Check warning on line 133 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:133:10 [readability-function-size]

function 'set_corner_meshes_in_mapping' exceeds recommended size/complexity thresholds
typename Model::Builder& builder,
const Model& other,
typename Model::Builder& other_builder,
Expand All @@ -146,11 +146,12 @@
other, other_corner.mesh().nb_vertices(),
other_corner.component_id() );
const auto& corner = model.corner( corner_id );
other_builder.unregister_mesh_component( other_corner );
builder.update_corner_mesh(
corner, other_builder.steal_corner_mesh( other_corner_id ) );
auto mesh_builder = builder.corner_mesh_builder( corner_id );
mesh_builder->set_id( corner.id() );
if( const auto name = corner.name() )

Check warning on line 154 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:154:28 [performance-unnecessary-copy-initialization]

the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference
{
mesh_builder->set_name( name.value() );
}
Expand All @@ -160,7 +161,7 @@
}

template < typename Model >
void set_line_meshes_in_mapping( const Model& model,

Check warning on line 164 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:164:10 [readability-function-size]

function 'set_line_meshes_in_mapping' exceeds recommended size/complexity thresholds
typename Model::Builder& builder,
const Model& other,
typename Model::Builder& other_builder,
Expand All @@ -175,11 +176,12 @@
const auto line_unique_vertices = save_mesh_unique_vertices( other,
other_line.mesh().nb_vertices(), other_line.component_id() );
const auto& line = model.line( line_id );
other_builder.unregister_mesh_component( other_line );
builder.update_line_mesh(
line, other_builder.steal_line_mesh( other_line_id ) );
auto mesh_builder = builder.line_mesh_builder( line_id );
mesh_builder->set_id( line.id() );
if( const auto name = line.name() )

Check warning on line 184 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:184:28 [performance-unnecessary-copy-initialization]

the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference
{
mesh_builder->set_name( name.value() );
}
Expand All @@ -189,7 +191,7 @@
}

template < typename Model >
void set_surface_meshes_in_mapping( const Model& model,

Check warning on line 194 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:194:10 [readability-function-size]

function 'set_surface_meshes_in_mapping' exceeds recommended size/complexity thresholds
typename Model::Builder& builder,
const Model& other,
typename Model::Builder& other_builder,
Expand All @@ -205,11 +207,12 @@
other, other_surface.mesh().nb_vertices(),
other_surface.component_id() );
const auto& surface = model.surface( surface_id );
other_builder.unregister_mesh_component( other_surface );
builder.update_surface_mesh(
surface, other_builder.steal_surface_mesh( other_surface_id ) );
auto mesh_builder = builder.surface_mesh_builder( surface_id );
mesh_builder->set_id( surface.id() );
if( const auto name = surface.name() )

Check warning on line 215 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:215:28 [performance-unnecessary-copy-initialization]

the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference
{
mesh_builder->set_name( name.value() );
}
Expand All @@ -219,7 +222,7 @@
}

template < typename Model >
void set_block_meshes_in_mapping( const Model& model,

Check warning on line 225 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:225:10 [readability-function-size]

function 'set_block_meshes_in_mapping' exceeds recommended size/complexity thresholds
typename Model::Builder& builder,
const Model& other,
typename Model::Builder& other_builder,
Expand All @@ -234,11 +237,12 @@
const auto block_unique_vertices = save_mesh_unique_vertices( other,
other_block.mesh().nb_vertices(), other_block.component_id() );
const auto& block = model.block( block_id );
other_builder.unregister_mesh_component( other_block );
builder.update_block_mesh(
block, other_builder.steal_block_mesh( other_block_id ) );
auto mesh_builder = builder.block_mesh_builder( block_id );
mesh_builder->set_id( block.id() );
if( const auto name = block.name() )

Check warning on line 245 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:245:28 [performance-unnecessary-copy-initialization]

the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference
{
mesh_builder->set_name( name.value() );
}
Expand All @@ -248,7 +252,7 @@
}
} // namespace

namespace geode

Check warning on line 255 in src/geode/model/representation/core/detail/transfer_meshes.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/model/representation/core/detail/transfer_meshes.cpp:255:1 [modernize-concat-nested-namespaces]

nested namespaces can be concatenated
{
namespace detail
{
Expand Down
Loading