fix(TransferMeshes): unregister mesh components while transferring m…

[BenPinet]

…eshes

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 12 concern(s)

• src/geode/model/representation/core/detail/transfer_meshes.cpp:51:27: warning: [readability-identifier-length]

  variable name 'in' is too short, expected at least 3 characters

     51 |         for( const auto& [in, _] :
        |                           ^

• src/geode/model/representation/core/detail/transfer_meshes.cpp:133:10: warning: [readability-function-size]

  function 'set_corner_meshes_in_mapping' exceeds recommended size/complexity thresholds

    133 |     void set_corner_meshes_in_mapping( const Model& model,
        |          ^
  /__w/OpenGeode/OpenGeode/src/geode/model/representation/core/detail/transfer_meshes.cpp:133:10: note: 6 parameters (threshold 4)

• src/geode/model/representation/core/detail/transfer_meshes.cpp:154:28: warning: [performance-unnecessary-copy-initialization]

  the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference

    154 |             if( const auto name = corner.name() )
        |                            ^
        |                           &

• src/geode/model/representation/core/detail/transfer_meshes.cpp:164:10: warning: [readability-function-size]

  function 'set_line_meshes_in_mapping' exceeds recommended size/complexity thresholds

    164 |     void set_line_meshes_in_mapping( const Model& model,
        |          ^
  /__w/OpenGeode/OpenGeode/src/geode/model/representation/core/detail/transfer_meshes.cpp:164:10: note: 6 parameters (threshold 4)

• src/geode/model/representation/core/detail/transfer_meshes.cpp:184:28: warning: [performance-unnecessary-copy-initialization]

  the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference

    184 |             if( const auto name = line.name() )
        |                            ^
        |                           &

• src/geode/model/representation/core/detail/transfer_meshes.cpp:194:10: warning: [readability-function-size]

  function 'set_surface_meshes_in_mapping' exceeds recommended size/complexity thresholds

    194 |     void set_surface_meshes_in_mapping( const Model& model,
        |          ^
  /__w/OpenGeode/OpenGeode/src/geode/model/representation/core/detail/transfer_meshes.cpp:194:10: note: 6 parameters (threshold 4)

• src/geode/model/representation/core/detail/transfer_meshes.cpp:215:28: warning: [performance-unnecessary-copy-initialization]

  the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference

    215 |             if( const auto name = surface.name() )
        |                            ^
        |                           &

• src/geode/model/representation/core/detail/transfer_meshes.cpp:225:10: warning: [readability-function-size]

  function 'set_block_meshes_in_mapping' exceeds recommended size/complexity thresholds

    225 |     void set_block_meshes_in_mapping( const Model& model,
        |          ^
  /__w/OpenGeode/OpenGeode/src/geode/model/representation/core/detail/transfer_meshes.cpp:225:10: note: 6 parameters (threshold 4)

• src/geode/model/representation/core/detail/transfer_meshes.cpp:245:28: warning: [performance-unnecessary-copy-initialization]

  the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference

    245 |             if( const auto name = block.name() )
        |                            ^
        |                           &

• src/geode/model/representation/core/detail/transfer_meshes.cpp:255:1: warning: [modernize-concat-nested-namespaces]

  nested namespaces can be concatenated

    255 | namespace geode
        | ^~~~~~~~~~~~~~~
    256 | {
        | ~
    257 |     namespace detail
        |     ~~~~~~~~~~~~~~~~
        |     namespace geode::detail

• src/geode/model/representation/core/detail/transfer_meshes.cpp:261:20: warning: [cppcoreguidelines-rvalue-reference-param-not-moved]

  rvalue reference parameter 'other' is never moved from inside the function body

    261 |             BRep&& other,
        |                    ^

• src/geode/model/representation/core/detail/transfer_meshes.cpp:285:23: warning: [cppcoreguidelines-rvalue-reference-param-not-moved]

  rvalue reference parameter 'other' is never moved from inside the function body

    285 |             Section&& other,
        |                       ^

Have any feedback or feature suggestions? Share it here.