fix: unmatched tracks not marked as Lost when dets_second is empty#2
Open
luigivicidomini wants to merge 1 commit intoGeekgineer:mainfrom
Open
fix: unmatched tracks not marked as Lost when dets_second is empty#2luigivicidomini wants to merge 1 commit intoGeekgineer:mainfrom
luigivicidomini wants to merge 1 commit intoGeekgineer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
ByteTrack::update, the entire second association stage was wrapped in a singleif (!detections_second.empty() && ...)block. When there are no low-confidence detections around (which is pretty common), the whole block gets skipped — including the part responsible for marking unmatched tracks asLost. Those tracks would just sit there withTrackedstate and never go away, effectively becoming ghost tracks.u_track2is now initialized with all indices ofr_tracked_stracks_ptrsbefore theifblock, and themark_lostloop has been moved outside of it so it always runs. Also removedu_detection2, which was being computed but never used anywhere.Type of Change
Checklist
Testing
Tested manually by running the tracker on a video sequence where a person leaves the frame. Before the fix, the track would persist indefinitely in
active_tracks_after the person disappeared. After the fix, the track is correctly marked asLostand eventually removed.Screenshots (if applicable)