-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add logic to intersect cell with a box in geos-trame #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add logic to intersect cell with a box in geos-trame #99
Conversation
00cd011 to
56878ff
Compare
|
@lucas-givord See #118 to understand the change in geos-trame pyproject,toml |
e9f194a to
5b56754
Compare
Previously user needs to trigger a render call to fix a bad scalar array/lut when a new data was added in the pyvista.Plotter. We enforce it when we trigger the 'update_viewer' method.
5b56754 to
79b26e7
Compare
looks like workflow edition trigger all test-integration. But could be justified
|
@lucas-givord it seems that Tho I tested with current (0.45.x) and newer (0.46.x) in a docker reproducer and the bug was persistent. Can you please check what version is on your side and if the resolution is fine by you ? |
|
thanks for debugging that @jafranc (and thanks @paloma-martinez for fixing the typo..), I'll check that today and let you know |
|
I'm surprised that pyvista doesn't call btw I use pyvista 0.45.2 and it works smoothly (osmesa version on my machine : 24.1.5). Thanks for your fix ! |
Ok, great ! I spotted the line where it could be added in |
This PR add support to render a Box. It also add support to render intersected cell in this box.
close #85
this PR depends on #96.