Skip to content

Conversation

@lucas-givord
Copy link
Contributor

This PR add support to render a Box. It also add support to render intersected cell in this box.

close #85

this PR depends on #96.

@alexbenedicto alexbenedicto changed the title feat: add logic to intersect cell with a box in geos-trame feat: add logic to intersect cell with a box in geos-trame Jun 20, 2025
@lucas-givord lucas-givord force-pushed the lgivord/feature/add_intersection_with_box branch from 00cd011 to 56878ff Compare July 8, 2025 12:15
@alexbenedicto
Copy link
Collaborator

@lucas-givord See #118 to understand the change in geos-trame pyproject,toml

@lucas-givord lucas-givord force-pushed the lgivord/feature/add_intersection_with_box branch from e9f194a to 5b56754 Compare August 5, 2025 08:28
Previously user needs to trigger a render call to fix a bad scalar
array/lut when a new data was added in the pyvista.Plotter. We enforce it
when we trigger the 'update_viewer' method.
@lucas-givord lucas-givord force-pushed the lgivord/feature/add_intersection_with_box branch from 5b56754 to 79b26e7 Compare September 1, 2025 09:40
@jafranc jafranc self-assigned this Oct 31, 2025
@jafranc jafranc added the test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI label Nov 3, 2025
looks like workflow edition trigger all test-integration. But could be justified
@jafranc
Copy link
Collaborator

jafranc commented Nov 3, 2025

@lucas-givord it seems that initialize() the pyvista's interactor was the solution to the raised bug in our CI combined with proper libomesa and gl deps.

Tho I tested with current (0.45.x) and newer (0.46.x) in a docker reproducer and the bug was persistent. Can you please check what version is on your side and if the resolution is fine by you ?

@lucas-givord
Copy link
Contributor Author

thanks for debugging that @jafranc (and thanks @paloma-martinez for fixing the typo..), I'll check that today and let you know

@lucas-givord
Copy link
Contributor Author

I'm surprised that pyvista doesn't call initialize() internally for the render window interactor, anyway in our case we need to call it so this fix make sense.

btw I use pyvista 0.45.2 and it works smoothly (osmesa version on my machine : 24.1.5).

Thanks for your fix !

@jafranc
Copy link
Collaborator

jafranc commented Nov 3, 2025

I'm surprised that pyvista doesn't call initialize() internally for the render window interactor, anyway in our case we need to call it so this fix make sense.

btw I use pyvista 0.45.2 and it works smoothly (osmesa version on my machine : 24.1.5).

Thanks for your fix !

Ok, great ! I spotted the line where it could be added in pyvista.
We'll merge this one and I'll post a follow-up issue and propose the fix on pyvista 's repo tagging you.

@paloma-martinez paloma-martinez merged commit b8fb53f into main Nov 3, 2025
56 checks passed
@paloma-martinez paloma-martinez deleted the lgivord/feature/add_intersection_with_box branch November 3, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI trame-UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

visualization of the well polylines, perforations, intersected cells and boxes

5 participants