feat: add scalar array selection in geos-trame #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-givord
force-pushed
the
lgivord/feature/add-scalar-arrays
branch
from
fc10795 to
1e24a93
Compare
lucas-givord
commented
Jun 12, 2025
geos-trame/tests/data/singlePhaseFlow/synthetic_random_arrays.vtu
Outdated
Show resolved
Hide resolved
lucas-givord
force-pushed
the
lgivord/feature/add-scalar-arrays
branch
from
1e24a93 to
a27e10d
Compare
Collaborator
|
Hello @lucas-givord, are this PR and PR #99 ready for review and merge ? And if so in which order ? |
Contributor
Author
|
Hello @alexbenedicto, this PR is not ready, I still need to fix a tiny bug then I'll put the label "ready for review". For the #99, I need a bit more work before being ready for a review |
lucas-givord
force-pushed
the
lgivord/feature/add-scalar-arrays
branch
from
a27e10d to
b9e6956
Compare
Contributor
Author
|
This PR should be ready now, @paloma-martinez could you please review it? |
paloma-martinez
approved these changes
Jun 24, 2025
Collaborator
paloma-martinez
left a comment
paloma-martinez
left a comment
There was a problem hiding this comment.
It looks fine to me
Contributor
Author
|
as paloma approved this PR, @alexbenedicto could you please merge it ? |
alexbenedicto
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in the
Deck Viewerthe ability to pick a specific scalar arrayclose #102