Skip to content

Conversation

@lucas-givord
Copy link
Contributor

@lucas-givord lucas-givord commented May 28, 2025

This PR implement a basic check logic to verify if some user input is valid based on the mesh.

Additionally, this PR enable mypy for geos-trame

close #88

close #101

@lucas-givord lucas-givord changed the title trame-geos: add logic to check user modification feat: add logic to check user modification in trame-geos May 28, 2025
@lucas-givord lucas-givord force-pushed the lgivord/feature/check_properties branch 2 times, most recently from a24f5b5 to 7239477 Compare June 2, 2025 09:54
@lucas-givord lucas-givord force-pushed the lgivord/feature/check_properties branch 3 times, most recently from 4b1b84b to 13b735d Compare June 3, 2025 09:08
@lucas-givord lucas-givord force-pushed the lgivord/feature/check_properties branch from 13b735d to ffe81fb Compare June 3, 2025 13:32
@alexbenedicto
Copy link
Collaborator

alexbenedicto commented Jun 5, 2025

Hello @lucas-givord , why did you remove the folder 'src' in your architecture?

All other geosPythonPackages projects like geos-posp, geos-mesh etc ... have the same architecture of:
"geos-feature/src/geos/feature/" instead of what you used with "geos-trame/geos-trame/"

What is your view on this ? @paloma-martinez

@lucas-givord
Copy link
Contributor Author

I didn't know that all other geos packages follow this structure, at least for consistency I should do the same thing.

Initially, I switch to a flat layout for simplicity but following an src/package layout is also nice (for installation step). The "geos-feature/src/geos/feature/" seems to be a variant of the src/package layout, by curiosity what is the rational to do that or is it a convention?

@paloma-martinez
Copy link
Collaborator

I think the "geos-feature/src/geos/feature/" layout allows to define and use geos namespace... You're right @alexbenedicto, it might be better to keep the same architecture for all packages in the repository...

@alexbenedicto alexbenedicto merged commit 8b51ff9 into main Jun 6, 2025
43 checks passed
@alexbenedicto alexbenedicto deleted the lgivord/feature/check_properties branch June 7, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants