-
Notifications
You must be signed in to change notification settings - Fork 0
feat: translate and rotate domains to clip the main frame #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RomainBaville
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests failed for me, may be an issue with the origin.
| from geos.mesh.utils.genericHelpers import getMultiBlockBounds | ||
|
|
||
| import numpy as np | ||
| import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An internal logger have been inplemented in geos.utils.Logger. You may give the chose to the user to use a personal handler (usefull for paraview) an use the internal logger by defaults.
RomainBaville
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good for me, you just may add typing for all your variable.
This PR introduces a new
clipToMainFrame.pymodifiers that derive the translation and rotation a hexahedral domain has undergone and revert it so the mesh has one extermal vertices set to (0,0,0) and is aligned with (X,Y,Z)This PR includes:
clipToMainFrame.pythat introduces:ClipToMainFramethat inherits fromvtkLandMarkTransformsetting itsSourcePtsandTargetPtsfrom mesh. It leverages to its best Object Bounding Box Tree struct to get is local frame.ClipToMainFramethat inherits fromvtkTransformFilterand is handlingvtkMultiBlockDataSetby fetching the block whose cell is selected as origin and computing rotation, translation from it to be applied globallytest_clipToMainFrame.pythat includes such :hexahedral mesh randomly rotated and translated and test the above utlis. For now it is only checking that the mesh:
a multiBlock mesh imported from reader to check integration (but nothing else)