feat: Create the PV plugin wrapping ClipToMainFrame #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafranc
changed the title
paloma-martinez
approved these changes
Sep 17, 2025
…m/GEOS-DEV/geosPythonPackages into jafranc/feat/PVTranslateAndRotate
RomainBaville
requested changes
Sep 19, 2025
Contributor
RomainBaville
left a comment
RomainBaville
left a comment
There was a problem hiding this comment.
The paraview plugin is good. You just need to change the initialisation of the filter to use the correct handler for the log in VTK
RomainBaville
approved these changes
Sep 24, 2025
Contributor
RomainBaville
left a comment
RomainBaville
left a comment
There was a problem hiding this comment.
It seems good for me, you can may be just add comment in case of multiBlockDataSet.
…m/GEOS-DEV/geosPythonPackages into jafranc/feat/PVTranslateAndRotate
paloma-martinez
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the PV plugin to wrap use of
ClipToMainFrame#130 in paraviewvtkMultiBlockDataSetas inputvtkUnstructuredGridas inputWait on #130 to be merged