Skip to content

Conversation

@Bubusch
Copy link
Contributor

@Bubusch Bubusch commented Feb 20, 2025

Add build based on pangea-4 config :

  • gcc@12.2.1
  • hpcx@2.20.0
  • intel-oneapi-mkl@2023.2.0

Linked to TPL-296

@Bubusch Bubusch mentioned this pull request Feb 19, 2025
11 tasks
@Bubusch Bubusch self-assigned this Feb 20, 2025
@Bubusch Bubusch added flag: requires updated TPL(s) Needs a specific TPL PR type: CI Concerns github workflows or generic CI labels Feb 20, 2025
@Bubusch Bubusch marked this pull request as ready for review February 20, 2025 09:11
@Bubusch Bubusch requested a review from rrsettgast as a code owner February 20, 2025 09:11
@Bubusch Bubusch requested a review from MelReyCG February 20, 2025 09:13
@Bubusch Bubusch added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Feb 20, 2025
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.31%. Comparing base (fb83361) to head (293fcce).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3561   +/-   ##
========================================
  Coverage    56.31%   56.31%           
========================================
  Files         1174     1174           
  Lines       102601   102601           
========================================
  Hits         57777    57777           
  Misses       44824    44824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bubusch Why is there no logs of unit-tests for the P4 GH job?
If you didn't run them because of the failing one, we can:

ctest -E "testPyCRSMatrix|testTensorOpsInverseOneArg|testTensorOpsInverseTwoArgs|testUncrustifyCheck|testDoxygenCheck"

(I excluded the testUncrustifyCheck as it is already done in the CI)

@paveltomin
Copy link
Collaborator

@Bubusch what is the status of this PR?

@herve-gross
Copy link
Contributor

@rrsettgast - as code owner can you review this small one (linked with GEOS-DEV/thirdPartyLibs#296)?

@Bubusch
Copy link
Contributor Author

Bubusch commented Aug 19, 2025

@Bubusch what is the status of this PR?

I still have to implement comments from @MelReyCG, I’ll revisit this PR once I’ve cleared a few other priorities.
Switching to draft meanwhile.

@Bubusch Bubusch marked this pull request as draft August 19, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires updated TPL(s) Needs a specific TPL PR type: CI Concerns github workflows or generic CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants