Skip to content

fix: handle non-numeric identity_pk in IdentityFeatureStateViewSet #7485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −1
Open

fix: handle non-numeric identity_pk in IdentityFeatureStateViewSet #7485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion api/features/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,12 @@ def get_queryset(self): # type: ignore[no-untyped-def]
if getattr(self, "swagger_fake_view", False):
return FeatureState.objects.none()

return super().get_queryset().filter(identity__pk=self.kwargs["identity_pk"]) # type: ignore[no-untyped-call]
identity_pk = self.kwargs["identity_pk"]
try:
int(identity_pk)
except (TypeError, ValueError):
return FeatureState.objects.none()
return super().get_queryset().filter(identity__pk=identity_pk) # type: ignore[no-untyped-call]

@action(methods=["GET"], detail=False)
def all(self, request, *args, **kwargs): # type: ignore[no-untyped-def]
Expand Down
21 changes: 21 additions & 0 deletions api/tests/unit/environments/identities/test_unit_identities_feature_states_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,3 +269,24 @@ def features_for_identity_clone_flag_states_from(
environment=environment,
identity=target_identity,
).exists()


def test_list_identity_feature_states__non_numeric_identity_pk__returns_empty(
environment: Environment,
staff_client: APIClient,
view_environment_permission: PermissionModel,
user_environment_permission: UserEnvironmentPermission,
) -> None:
# Given
user_environment_permission.permissions.add(view_environment_permission)
url = reverse(
"api-v1:environments:identity-featurestates-list",
args=(environment.api_key, "org_3COWhASRXfhcdxVrd0wEjpQp4dg"),
)

# When
response = staff_client.get(url)

# Then
assert response.status_code == status.HTTP_200_OK
assert response.json() == []
Loading