fix: handle non-numeric identity_pk in IdentityFeatureStateViewSet#7485
Open
SAY-5 wants to merge 1 commit into
Open
fix: handle non-numeric identity_pk in IdentityFeatureStateViewSet#7485SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Validate identity_pk before passing to the ORM filter so that non-numeric URL captures return an empty queryset instead of raising ValueError in the model field. Contributes to Flagsmith#6809 Fixes Flagsmith#7361 Signed-off-by: say <say.apm35@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
@SAY-5 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7361.
/api/v1/environments/<key>/identities/<identity_pk>/featurestates/crashes with ValueError whenidentity_pkis non-numeric (e.g. an external identifier passed through by mistake), because Django's ORM tries to coerce it to int for theidentity__pklookup.This mirrors the approach in #7443: validate the value up front and return an empty queryset for non-numeric ids, so the API responds 200 with
[]instead of 500.Contributes to #6809.