Extend `mypy` checks to `test/` and `demo/` by schnellerhase · Pull Request #4135 · FEniCS/dolfinx

schnellerhase · 2026-03-20T14:34:00Z

Adds locally reproducible CI behaviour (Makefile with venv)
Extends checks to test/ and demo/ files
Enables (CI) checking of further type fixes to follow in Add typing generics #4131
Fix: type of dirichletbc arg - Number is typing incompatible https://peps.python.org/pep-0484/#the-numeric-tower.

TODO (future):

Extend the mypy execution to (one) PETSc enabled setup - those raise still errors and are untested
Extend the venv based linting to other tools (same benefit of reproducibility and non-manual configuration)

schnellerhase force-pushed the schnellerhase/mypy-demo/test branch from 6f80a70 to 9b9ae01 Compare March 20, 2026 14:39

schnellerhase added 2 commits March 20, 2026 15:57

Add reproducible mypy make recipe

f82f667

Mypy check test/

452f4ae

schnellerhase self-assigned this Mar 20, 2026

schnellerhase added ci Continuous Integration type-hints labels Mar 20, 2026

schnellerhase force-pushed the schnellerhase/mypy-demo/test branch from c3e3fca to adb6872 Compare March 20, 2026 15:11

schnellerhase added 2 commits March 20, 2026 16:13

Fix: dbc value type

4cb783a

Mypy check (and fix) demo/

a75f18d

schnellerhase force-pushed the schnellerhase/mypy-demo/test branch from adb6872 to a75f18d Compare March 20, 2026 15:13

schnellerhase marked this pull request as ready for review March 20, 2026 15:25

schnellerhase requested review from chrisrichardson, jorgensd and michalhabera March 20, 2026 15:25

Provide feedback