Draft
Conversation
schnellerhase
force-pushed
the
schnellerhase/generics
branch
8 times, most recently
from
eb8ca0f to
b5dadfb
Compare
schnellerhase
force-pushed
the
schnellerhase/generics
branch
from
75691d8 to
efd17c2
Compare
schnellerhase
force-pushed
the
schnellerhase/generics
branch
from
b5f116f to
37b3898
Compare
Member
|
Looks good - have you considered directly mimicking the naming/setup of the C++ concepts? Perhaps they could also be put somewhere more general for use across the whole interface. https://github.com/FEniCS/dolfinx/blob/main/cpp/dolfinx/common/types.h#L26 |
schnellerhase
force-pushed
the
schnellerhase/generics
branch
from
1cde704 to
6d5be09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the approach of #4094 for multi export type wrappers to
VectorMatrixCSRSuperLUDistMatrixSuperLUDistSolverDirichletBCCoordinateElementFiniteElementFormConstantExpressionFunctionFunctionSpaceMeshGeometryCoordinateElementNecessary for #4101.