Implement a fast enough data component.#1105
Open
wuke32767 wants to merge 1 commit intoEverestAPI:devfrom
Open
Implement a fast enough data component.#1105wuke32767 wants to merge 1 commit intoEverestAPI:devfrom
wuke32767 wants to merge 1 commit intoEverestAPI:devfrom
Conversation
maddie480-bot
added
the
1: review needed
wuke32767
force-pushed
the
data-component
branch
from
7648957 to
2c50b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not too glad with the current way to attach fields to an entity.
DynamicData.ForandComponentare both slow (to me).That's why I made this. Why has no one ever done this before?
Advantage
Fast.
Implementation
Now
Entityholds a two-dimensional array. It stores all attached fields.The first dimension stands for the depth of the entity in the inheritance tree.
Users can register their fields to a type, and the second dimension is the unique index they got.
Any fields are attached to only one type (and it's subtype), it can't work as a universal component.
It handles inheritance by depth dimension. Any child entity will be able to access fields attached to the parent entity, naturally.
Any type safe issue is done by hidding the implementation details.