implement a super fast data component.#1104
Closed
wuke32767 wants to merge 1 commit intoEverestAPI:devfrom
Closed
Conversation
maddie480-bot
added
the
1: review needed
Contributor
Author
|
:sobeline: i have noticed an issue which causes it to be not super fast. i'm going to close this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not too glad with the current way to attach fields to an entity.
DynamicData.ForandComponentare both too slow (to me).That's why I made this. Why would someone do this?
Advantage
Super fast.
Disadvantage
Add confusing sht to EVERY (EVERY!) entity.
It's slower for the first time loading.
Implementation
#1105 The two-dimensional array is torn apart by depth and scattered into EVERY subtype.