Skip to content

Add missing length check in EncodeEPath function #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinMelikMerkumians merged 1 commit into from
May 29, 2026
+11 −9
Merged

Add missing length check in EncodeEPath function #578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions source/src/cip/cipcommon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,15 +1342,17 @@ void EncodeEPath(const void *const data,
unsigned int length = epath->path_size;
size_t start_length = message->used_message_length;

if(epath->class_id < 256) {
AddSintToMessage(0x20, message); /* 8 Bit Class Id */
AddSintToMessage( (EipUint8) epath->class_id, message );
length -= 1;
} else {
AddSintToMessage(0x21, message); /*16Bit Class Id */
AddSintToMessage(0, message); /*pad byte */
AddIntToMessage(epath->class_id, message);
length -= 2;
if(0 < length) {
if(epath->class_id < 256) {
AddSintToMessage(0x20, message); /* 8 Bit Class Id */
AddSintToMessage( (EipUint8) epath->class_id, message );
length -= 1;
} else {
AddSintToMessage(0x21, message); /*16Bit Class Id */
AddSintToMessage(0, message); /*pad byte */
AddIntToMessage(epath->class_id, message);
length -= 2;
}
}

if(0 < length) {
Expand Down
Loading