Add missing length check in EncodeEPath function#578
Merged
Conversation
EncodeEpath assumes that at the very least the Epath it has been given has at least one segment. This is not necessarily true. Take for example the TCP/IP interface object attribute 4. For a device with multiple physical interfaces that correspond to the TCP/IP interface, this attribute can contain a path size of zero. Without this check the encoding will be wrong and the assertion present in this function will fail.
Member
|
Thanks for your contribution @MaxjATL |
MartinMelikMerkumians
approved these changes
May 29, 2026
MartinMelikMerkumians
merged commit 36943e6
into
EIPStackGroup:master
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncodeEpath assumes that at the very least the Epath it has been given has at least one segment. This is not necessarily true. Take for example the TCP/IP interface object attribute 4. For a device with multiple physical interfaces that correspond to the TCP/IP interface, this attribute can contain a path size of zero.
Without this check the encoding will be wrong and the assertion present in this function will fail.