Skip to content

Untracked: Remove code added by mistake #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrwishart merged 2 commits into from
Oct 17, 2025
Merged

Untracked: Remove code added by mistake #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
476f164
Untracked: Remove code added by mistake
jrwishart Oct 16, 2025
068d6dc
Reduce nesting
jrwishart Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 23 additions & 29 deletions R/mergingandstackingutilities.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,39 +326,33 @@ splitByComma <- function(input.text, ignore.commas.in.parentheses = FALSE)
split.text <- trimws(strsplit(input.text, ",")[[1]])
return(split.text[split.text != ""])
}
else
split.char <- strsplit(input.text, "")[[1]]
result <- c()
start.ind <- NA_integer_
in.parentheses <- FALSE
for (i in seq_along(split.char))
{
split.char <- strsplit(input.text, "")[[1]]
result <- c()
start.ind <- NA_integer_
in.parentheses <- FALSE
for (i in seq_along(split.char))
if (is.na(start.ind))
{
if (is.na(start.ind))
{
if (split.char[i] != ",")
start.ind <- i
else
next
}
if (split.char[i] != ",")
start.ind <- i
else
next
}

if (!in.parentheses && split.char[i] == ",")
{
result <- c(result, paste0(split.char[start.ind:(i - 1)],
collapse = ""))
start.ind <- NA_integer_
}
else if (i == length(split.char))
result <- c(result, paste0(split.char[start.ind:i],
collapse = ""))
else if (!in.parentheses && split.char[i] == "(")
in.parentheses <- TRUE
else if (in.parentheses && split.char[i] == ")")
in.parentheses <- FALSE
if (!in.parentheses && split.char[i] == ",")
{
result <- c(result, paste0(split.char[start.ind:(i - 1)],
collapse = ""))
start.ind <- NA_integer_
}
result <- trimws(result)
result <- result[result != ""]
result
else if (i == length(split.char))
result <- c(result, paste0(split.char[start.ind:i],
collapse = ""))
else if (!in.parentheses && split.char[i] == "(")
in.parentheses <- TRUE
else if (in.parentheses && split.char[i] == ")")
in.parentheses <- FALSE
}
result <- trimws(result)
Copy link
Contributor

@JustinCCYap JustinCCYap Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that since the if case returns early, you can remove the else to reduce nesting and reduce the chance of these mistakes

result <- result[result != ""]
Expand Down
Loading